Bug 108816

Summary: [EFL][WK2] Stop using libsoup in ewk_url_scheme_request
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit EFLAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, ap, benjamin, gyuyoung.kim, kenneth, laszlo.gombos, lucas.de.marchi, mikhail.pozdnyakov, rakuco, sam, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 107657    
Attachments:
Description Flags
Patch none

Description Chris Dumez 2013-02-04 04:31:15 PST 
As we are trying to minimize use of external dependencies in our WK2 EFL API implementation, we should stop using libsoup in ewk_url_scheme_request and use the WK2 C API instead.
Comment 1 Chris Dumez 2013-02-04 04:34:04 PST 
Created attachment 186351 [details]
Patch
Comment 2 Mikhail Pozdnyakov 2013-02-04 04:38:27 PST 
Comment on attachment 186351 [details]
Patch

Makes sense. LGTM
Comment 3 Kenneth Rohde Christiansen 2013-02-04 05:03:54 PST 
Comment on attachment 186351 [details]
Patch

Looks good to me too
Comment 4 Build Bot 2013-02-04 07:17:41 PST 
Comment on attachment 186351 [details]
Patch

Attachment 186351 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/16372235
Comment 5 Chris Dumez 2013-02-04 07:24:07 PST 
Comment on attachment 186351 [details]
Patch

win-ews is in a bad state. The error looks unrelated. Setting cq? flag again.
Comment 6 WebKit Review Bot 2013-02-04 10:33:40 PST 
Comment on attachment 186351 [details]
Patch

Clearing flags on attachment: 186351

Committed r141780: <http://trac.webkit.org/changeset/141780>
Comment 7 WebKit Review Bot 2013-02-04 10:33:45 PST 
All reviewed patches have been landed.  Closing bug.