Summary: | Update CaptionUserPreferences | ||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Eric Carlson <eric.carlson> | ||||||||||||||
Component: | Media | Assignee: | Eric Carlson <eric.carlson> | ||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||
Severity: | Normal | CC: | buildbot, dino, feature-media-reviews, ojan.autocc, rniwa, webkit.review.bot | ||||||||||||||
Priority: | P2 | ||||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||
OS: | Unspecified | ||||||||||||||||
Attachments: |
|
Description
Eric Carlson
2013-02-03 18:12:40 PST
Created attachment 186294 [details]
Proposed patch
Attachment 186294 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/page/CaptionUserPreferences.h', u'Source/WebCore/page/CaptionUserPreferencesMac.h', u'Source/WebCore/page/CaptionUserPreferencesMac.mm', u'Source/WebCore/platform/Language.cpp', u'Source/WebCore/platform/Language.h', u'Source/WebCore/platform/graphics/avfoundation/objc/InbandTextTrackPrivateAVFObjC.mm']" exit_code: 1
Source/WebCore/page/CaptionUserPreferences.h:52: Too many spaces inside { }. [whitespace/braces] [5]
Total errors found: 1 in 7 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 186294 [details] Proposed patch Attachment 186294 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://queues.webkit.org/results/16365119 Created attachment 186296 [details]
Update patch for my good friend the style bot.
Created attachment 186298 [details]
Another update.
Comment on attachment 186298 [details] Another update. Attachment 186298 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://queues.webkit.org/results/16371034 Created attachment 186304 [details]
One more time...
Comment on attachment 186304 [details] One more time... Attachment 186304 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://queues.webkit.org/results/16371062 Comment on attachment 186304 [details] One more time... Attachment 186304 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/16357966 Created attachment 186373 [details]
Another update.
Comment on attachment 186373 [details] Another update. Attachment 186373 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/16371312 (In reply to comment #11) > (From update of attachment 186373 [details]) > Attachment 186373 [details] did not pass win-ews (win): > Output: http://queues.webkit.org/results/16371312 Not likely to be related: 1>..\cg\ImageDiffCG.cpp(37) : fatal error C1083: Cannot open include file: 'wtf/Platform.h': No such file or directory 1>Build log was saved at "file://C:\cygwin\home\buildbot\WebKit\WebKitBuild\Release\obj\ImageDiff\BuildLog.htm" Created attachment 186420 [details]
Updated patch
Comment on attachment 186420 [details] Updated patch View in context: https://bugs.webkit.org/attachment.cgi?id=186420&action=review > Source/WebCore/page/CaptionUserPreferencesMac.mm:95 > - > + Nit: indent added? > Source/WebCore/page/CaptionUserPreferencesMac.mm:185 > + builder.append(" !important"); Technically I don't think you need the space before the "!", but it doesn't hurt. Comment on attachment 186420 [details] Updated patch http://trac.webkit.org/r141790 |