| Summary: | Add Antoine Quint to the list of committers | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Antoine Quint <graouts> | ||||
| Component: | New Bugs | Assignee: | Antoine Quint <graouts> | ||||
| Status: | RESOLVED INVALID | ||||||
| Severity: | Normal | CC: | abarth, dino, dpranke, eric, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Antoine Quint
2013-02-02 05:24:55 PST
Created attachment 186226 [details]
Patch
Comment on attachment 186226 [details] Patch Clearing flags on attachment: 186226 Committed r141693: <http://trac.webkit.org/changeset/141693> All reviewed patches have been landed. Closing bug. Rolled out in r141698. It is not allowed to use commit queue to become a committer, this change must be landed manually (no review needed, no bugzilla bug needed). This proves that Apple actually received committer agreement, and created an account. This admittedly makes less sense for Apple employees, but doing this differently is misleading. (In reply to comment #4) > Rolled out in r141698. It is not allowed to use commit queue to become a committer, this change must be landed manually (no review needed, no bugzilla bug needed). > > This proves that Apple actually received committer agreement, and created an account. This admittedly makes less sense for Apple employees, but doing this differently is misleading. No problem. I'll land manually. Landed in http://trac.webkit.org/changeset/141707 (even though we don't need a bugzilla) (In reply to comment #6) > Landed in http://trac.webkit.org/changeset/141707 > (even though we don't need a bugzilla) The point is that Antoine is supposed to land it to prove he has rights. :) (In reply to comment #7) > (In reply to comment #6) > > Landed in http://trac.webkit.org/changeset/141707 > > (even though we don't need a bugzilla) > > The point is that Antoine is supposed to land it to prove he has rights. :) OMG! Now I get it!! I'm not sure what was wrong with my brain that caused me to not understand this :) Honestly, I think this was a senior moment. |