Summary: | [chromium] Flings should not bubble up to enclosing scrollables when main-thread touch scrolling | ||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Terry Anderson <tdanderson> | ||||||||||||||
Component: | Platform | Assignee: | Terry Anderson <tdanderson> | ||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||
Severity: | Normal | CC: | abarth, dglazkov, eric, fishd, jamesr, jochen, leviw, ojan.autocc, peter+ews, rjkroege, simon.fraser, tkent+wkapi, webkit.review.bot | ||||||||||||||
Priority: | P2 | ||||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||
OS: | Unspecified | ||||||||||||||||
Bug Depends on: | 108849 | ||||||||||||||||
Bug Blocks: | |||||||||||||||||
Attachments: |
|
Description
Terry Anderson
2013-02-01 15:53:30 PST
Created attachment 186177 [details]
WIP
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. FWIW: the fling code in WebViewImpl and related event changes look good to me. Created attachment 186445 [details]
Patch
Comment on attachment 186445 [details] Patch Attachment 186445 [details] did not pass cr-linux-debug-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16374325 Comment on attachment 186445 [details] Patch Attachment 186445 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16371423 Comment on attachment 186445 [details] Patch Attachment 186445 [details] did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/16378284 Created attachment 186912 [details]
Patch
Comment on attachment 186912 [details] Patch Attachment 186912 [details] did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/16394390 Created attachment 186953 [details]
Patch
Created attachment 187091 [details]
Patch
Looks very reasonable. :) How does one test this? Comment on attachment 187091 [details] Patch Attachment 187091 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/16428331 (In reply to comment #12) > Looks very reasonable. :) How does one test this? I have tested the behavior of the new event type GestureScrollUpdateWithoutPropagation in isolation for https://bugs.webkit.org/show_bug.cgi?id=108849, and testing fling itself (such as in fast/events/touch/gesture/pad-gesture-fling.html) is notoriously flaky. Created attachment 187173 [details]
Patch
Comment on attachment 187173 [details]
Patch
I worry w/o automated testing this will break again. :(
(In reply to comment #16) > (From update of attachment 187173 [details]) > I worry w/o automated testing this will break again. :( I definitely agree that some reliable automated testing for fling gestures would be welcome (but in speaking with @rjkroege, this will likely require a substantial effort to make robust). I have filed https://bugs.webkit.org/show_bug.cgi?id=109234 to track. Comment on attachment 187173 [details] Patch Clearing flags on attachment: 187173 Committed r142197: <http://trac.webkit.org/changeset/142197> All reviewed patches have been landed. Closing bug. |