| Summary: | Update LayoutTests scripts to skip webgl folder on ports | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Gregg Tavares <gman> | ||||||||
| Component: | WebGL | Assignee: | Gregg Tavares <gman> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | abarth, dpranke, eric, kbr, webkit.review.bot | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | All | ||||||||||
| OS: | All | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Gregg Tavares
2013-02-01 15:11:25 PST
Created attachment 186156 [details]
Patch
Before I check in the WebGL Conformance Tests I think I need this change so that ports that do not support WebGL skip the tests Attachment 186156 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/Scripts/webkitpy/layout_tests/port/base.py', u'Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py']" exit_code: 1
Tools/ChangeLog:8: Line contains tab character. [whitespace/tab] [5]
Tools/ChangeLog:9: Line contains tab character. [whitespace/tab] [5]
Tools/ChangeLog:10: Line contains tab character. [whitespace/tab] [5]
Tools/ChangeLog:11: Line contains tab character. [whitespace/tab] [5]
Total errors found: 4 in 3 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 186156 [details]
Patch
looks fine. fix the style errors :)
Created attachment 186161 [details]
Patch
Created attachment 186164 [details]
Patch
Comment on attachment 186164 [details] Patch Clearing flags on attachment: 186164 Committed r141672: <http://trac.webkit.org/changeset/141672> All reviewed patches have been landed. Closing bug. |