Bug 108693

Summary: Make ConfigurationBuildDir include directories precede WebKitLibraries in JSC
Product: WebKit Reporter: Roger Fong <roger_fong>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, roger_fong, thorton
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows 7   
Attachments:
Description Flags
patch none

Roger Fong
Reported 2013-02-01 14:20:50 PST
ConfigurationBuildDir includes should precede WebKitLibraries. This is because some files in the newer WebKitLibaries versions have overlapping files "include/private/wtf". These files will not necessarily match up with whatever is on ToT since new WebKitLibraries are only released periodically. This caused build issues when using a newer WebKitLibraries version, specifically in JSC. JSC should prioritize the files in the build directory which are copied from ToT when searching for file includes. This might also be an issue in other projects down the road but I think taking a "fix it as they come" approach is better here.
Attachments
patch (2.46 KB, patch)
2013-02-01 14:23 PST, Roger Fong 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Roger Fong
Comment 1 2013-02-01 14:23:37 PST
Created attachment 186138 [details] patch
Roger Fong
Comment 2 2013-02-05 13:13:58 PST
Comment on attachment 186138 [details] patch rubberstamped by thorton
Roger Fong
Comment 3 2013-02-05 13:18:56 PST
http://trac.webkit.org/changeset/141921
Note You need to log in before you can comment on or make changes to this bug.