Bug 108692

Summary: Web Inspector: add round braces to javascript tokenizer
Product: WebKit Reporter: Andrey Lushnikov <lushnikov>
Component: Web Inspector (Deprecated)Assignee: Andrey Lushnikov <lushnikov>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, keishi, loislo, pfeldman, pmuellr, vsevik, web-inspector-bugs, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 108697    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Andrey Lushnikov
Reported 2013-02-01 14:17:19 PST
Add round braces to javascript tokenizer.
Attachments
Patch (155.87 KB, patch)
2013-02-01 14:23 PST, Andrey Lushnikov 		no flags
DetailsFormatted DiffDiff
Patch (167.68 KB, patch)
2013-02-01 14:54 PST, Andrey Lushnikov 		no flags
DetailsFormatted DiffDiff
Patch (16.51 KB, patch)
2013-02-02 13:06 PST, Andrey Lushnikov 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Andrey Lushnikov
Comment 1 2013-02-01 14:18:10 PST
This change will be used in brace highlighter functionality.
Andrey Lushnikov
Comment 2 2013-02-01 14:23:15 PST
Created attachment 186137 [details] Patch
Andrey Lushnikov
Comment 3 2013-02-01 14:39:23 PST
Comment on attachment 186137 [details] Patch testcases not updated.
Andrey Lushnikov
Comment 4 2013-02-01 14:54:52 PST
Created attachment 186149 [details] Patch
Pavel Feldman
Comment 5 2013-02-02 03:59:02 PST
Comment on attachment 186149 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=186149&action=review > Source/WebCore/inspector/front-end/SourceJavaScriptTokenizer.re2js:-180 > - <DIV,NODIV> RightParen => DIV { this.tokenType = null; return cursor; } DIV,NODIV => DIV means that we transition from the state where division is expected or not expected into the state where it is expected (this is due to "/" ambiguity - it might be division or regex start).
Andrey Lushnikov
Comment 6 2013-02-02 13:06:45 PST
Created attachment 186235 [details] Patch
Andrey Lushnikov
Comment 7 2013-02-02 13:07:56 PST
Comment on attachment 186149 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=186149&action=review >> Source/WebCore/inspector/front-end/SourceJavaScriptTokenizer.re2js:-180 >> - <DIV,NODIV> RightParen => DIV { this.tokenType = null; return cursor; } > > DIV,NODIV => DIV means that we transition from the state where division is expected or not expected into the state where it is expected (this is due to "/" ambiguity - it might be division or regex start). thanks for clarifying this moment!
Build Bot
Comment 8 2013-02-02 14:14:10 PST
Comment on attachment 186235 [details] Patch Attachment 186235 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/16343994
Build Bot
Comment 9 2013-02-02 15:15:29 PST
Comment on attachment 186235 [details] Patch Attachment 186235 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/16359020
WebKit Review Bot
Comment 10 2013-02-04 09:43:55 PST
Comment on attachment 186235 [details] Patch Clearing flags on attachment: 186235 Committed r141774: <http://trac.webkit.org/changeset/141774>
WebKit Review Bot
Comment 11 2013-02-04 09:43:59 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.