Bug 108685

Summary: Web Inspector: fix bug in highlighting single chars via highlightRange API of DTE
Product: WebKit Reporter: Andrey Lushnikov <lushnikov>
Component: Web Inspector (Deprecated)Assignee: Andrey Lushnikov <lushnikov>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, buildbot, keishi, loislo, pfeldman, pmuellr, rniwa, vsevik, web-inspector-bugs, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 108679    
Bug Blocks: 108697    
Attachments:
Description Flags
Patch
none
Patch none

Andrey Lushnikov
Reported 2013-02-01 13:44:50 PST
if you try to highlight a single char via highlightRange method of DTE, it will actually highlight all the way to the end of the line.
Attachments
Patch (4.73 KB, patch)
2013-02-01 13:51 PST, Andrey Lushnikov 		no flags
DetailsFormatted DiffDiff
Patch (4.57 KB, patch)
2013-02-01 21:42 PST, Andrey Lushnikov 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andrey Lushnikov
Comment 1 2013-02-01 13:47:12 PST
to reviewer: this bug depends on https://bugs.webkit.org/show_bug.cgi?id=108679, so please do not cq+ it unless that one is landed.
Andrey Lushnikov
Comment 2 2013-02-01 13:51:10 PST
Created attachment 186129 [details] Patch
Build Bot
Comment 3 2013-02-01 15:57:24 PST
Comment on attachment 186129 [details] Patch Attachment 186129 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/16336261 New failing tests: inspector/editor/text-editor-highlight-api.html
Build Bot
Comment 4 2013-02-01 16:39:57 PST
Comment on attachment 186129 [details] Patch Attachment 186129 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/16343194
Build Bot
Comment 5 2013-02-01 17:38:08 PST
Comment on attachment 186129 [details] Patch Attachment 186129 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/16330371
Andrey Lushnikov
Comment 6 2013-02-01 21:42:03 PST
Created attachment 186214 [details] Patch
Build Bot
Comment 7 2013-02-01 23:51:20 PST
Comment on attachment 186214 [details] Patch Attachment 186214 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/16337621
Build Bot
Comment 8 2013-02-02 01:38:51 PST
Comment on attachment 186214 [details] Patch Attachment 186214 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/16340592
WebKit Review Bot
Comment 9 2013-02-02 04:00:00 PST
Comment on attachment 186214 [details] Patch Clearing flags on attachment: 186214 Committed r141689: <http://trac.webkit.org/changeset/141689>
WebKit Review Bot
Comment 10 2013-02-02 04:00:04 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.