Bug 10862 – REGRESSION: Collapsing form input on www.myspace.com

• Component: Forms
• Status: RESOLVED WORKSFORME

[Miles Bainbridge]

On nightly builds of WebKit (I belive from 9-12-2006 and later), if you go to www.myspace.com, and start typing in the password box, the text input box labeled "E-Mail:" collapses to a width of less than 10 pixels.  If memory serves correctly, I did not experience this on builds from 9-11-2006 and earlier, and I have experienced this on multiple different computers running nightly builds since then, all running Mac OS X 10.4.7.  Also, all of the computers I have tested this on have been PowerPC.  I can attach screen shots if requested.

[Miles Bainbridge]

Created attachment 10562 [details]
Screen shot of collapsed text enry box.

This screen shot is from WebKit nightly build 9-11-2006.  The bug is still occurring in nightly build 9-13-2006

[Miles Bainbridge]

Correction - I have a screen shot on file (which I just attached) that indicates that this bug started occurring with the nightly build from 9-11-2006.

[Kevin M. Dean]

I'm seeing the same. It appears that you have to type at least 1 character in the E-mail field before selecting the password field and type to trigger the problem. If your E-mail is already there and you got directly to the password fiedl and type, everthing's fine.

Created attachment 10573 [details]
Reduction

Very similar to bug 9316!

The wrong layout is the due to the subtree layout mechanism being triggered when it shouldn't be. It happens as a result of calling setNeedsLayout() on a new RenderText which doesn't have a parent yet (this happens under setStyle() under createRendererIfNeeded()). RenderObject::scheduleRelayout() is confused as a result of this. In its "else" case, it should simply do nothing if parent() is 0.

[Miles Bainbridge]

I just did some checking on where this bug orriginated, and it seems to have started appearing in build 16265.  16259 and earlier do not exhibit this, though they have some even more serious layout issues on the same web page.

[Stephanie Lewis]

radar 4823120

[Kevin B]

this works for me in r17878

(In reply to comment #9)
> this works for me in r17878
> 

That's because r17543 moved text controls back to RenderBlock. The root cause of this bug should still be fixed.

[Matt Lilek]

I can still reproduce this, but in a different way.  Load myspace.com, enter anything in either the username or password field, then click the the search button in the upper right hand of the page - the text field collapses like before.

[Matt Lilek]

Created attachment 11623 [details]
new reduction

This is a reduction for the behavior I described in my last comment.  This bug is identical to bug 9316 except instead of collapsing on a keystroke, it collapses on any kind of a button press (this can be verified by modifying 9316's testcase to include a button).  On myspace, it only happens like I described because "login" and "sign up" are faux buttons.

[Matt Lilek]

*** Bug 11317 has been marked as a duplicate of this bug. ***

[Adele Peterson]

This appears to be fixed in TOT.

(In reply to comment #10)
> That's because r17543 moved text controls back to RenderBlock. The root cause
> of this bug should still be fixed.
> 

Bug 13525.