Bug 108602

Summary: Web Inspector: [Canvas] UI is not restored properly when deleting a live recording profile
Product: WebKit Reporter: Andrey Adaikin <aandrey>
Component: Web Inspector (Deprecated)Assignee: Andrey Adaikin <aandrey>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, keishi, loislo, pfeldman, pmuellr, vsevik, web-inspector-bugs, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Description Andrey Adaikin 2013-02-01 02:05:08 PST 
Repro:
- start recording canvas consecutive frames
- while recording, delete the profile header
- observe the start button's color is still red

Patch to follow.
Comment 1 Andrey Adaikin 2013-02-01 02:11:42 PST 
Created attachment 185985 [details]
Patch
Comment 2 Pavel Feldman 2013-02-04 00:25:47 PST 
Comment on attachment 185985 [details]
Patch

Missing a test.
Comment 3 Andrey Adaikin 2013-02-04 03:31:47 PST 
(In reply to comment #2)
> (From update of attachment 185985 [details])
> Missing a test.

UI change, manual testing. I dont think we test these.
Comment 4 Pavel Feldman 2013-02-04 03:41:26 PST 
Comment on attachment 185985 [details]
Patch

At this point, I don't think proceeding with no tests at all is acceptable. We need at least some acceptance tests.
Comment 5 WebKit Review Bot 2013-02-05 04:06:13 PST 
Comment on attachment 185985 [details]
Patch

Clearing flags on attachment: 185985

Committed r141883: <http://trac.webkit.org/changeset/141883>
Comment 6 WebKit Review Bot 2013-02-05 04:06:18 PST 
All reviewed patches have been landed.  Closing bug.