Bug 108588

Summary:

[Gtk][WK2] Fix build after recent WebKit2 changes

Product:

WebKit

Reporter:

Seulgi Kim <dev>

Component:

New Bugs

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca, dev, hausmann, kling, webkit.review.bot

Priority:

Version:

525.x (Safari 3.2)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch for landing	skyul: commit-queue+

Description Seulgi Kim 2013-01-31 23:42:12 PST

Do the same as https://bugs.webkit.org/show_bug.cgi?id=108548

Comment 1 Seulgi Kim 2013-01-31 23:58:47 PST

Created attachment 185958 [details]
Patch

Comment 2 EFL EWS Bot 2013-02-01 00:55:54 PST

Comment on attachment 185958 [details]
Patch

Attachment 185958 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/16296476

Comment 3 Seulgi Kim 2013-02-01 01:38:45 PST

Created attachment 185976 [details]
Patch

Comment 4 Simon Hausmann 2013-02-01 02:36:15 PST

Patch looks pretty good, almost identical to the fix to WorkQueueQt.cpp in http://trac.webkit.org/changeset/141528/trunk/Source/WebKit2/Platform/qt/WorkQueueQt.cpp

Comment 5 WebKit Review Bot 2013-02-01 02:40:40 PST

Comment on attachment 185976 [details]
Patch

Rejecting attachment 185976 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=gce-cq-02', 'validate-changelog', '--non-interactive', 185976, '--port=chromium-xvfb']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue

/mnt/git/webkit-commit-queue/Source/WebKit2/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/16297605

Comment 6 Seulgi Kim 2013-02-01 02:50:37 PST

Created attachment 185998 [details]
Patch for landing

Comment 7 Simon Hausmann 2013-02-01 04:56:29 PST

Committed r141580: <http://trac.webkit.org/changeset/141580>