Bug 108582 – REGRESSION(r111639): delayed animation start can be postponed

• Component: New Bugs
• Status: RESOLVED FIXED

REGRESSION(r111639): delayed animation start can be postponed

Created attachment 185948 [details]
Patch

[WebKit Review Bot]

Comment on attachment 185948 [details]
Patch

Attachment 185948 [details] did not pass cr-linux-debug-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/16302453

[Alan Cutter]

(In reply to comment #2)
> (From update of attachment 185948 [details])
> Attachment 185948 [details] did not pass cr-linux-debug-ews (chromium-xvfb):
> Output: http://queues.webkit.org/results/16302453

This reported failure was due to this change in the cr-linux-debug-ews bots: bug 108512

Comment on attachment 185948 [details]
Patch

cr-linux-debug failure is spurious

[Darin Adler]

Comment on attachment 185948 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=185948&action=review

> Source/WebCore/page/animation/AnimationController.cpp:129
> +    if (m_animationTimer.isActive() && (m_animationTimer.repeatInterval() || m_animationTimer.nextFireInterval() <= timeToNextService))
> +        return;

The use of repeat interval in this class is peculiar. I don’t understand the comment at all. It says “to reduce the overhead of starting”.

[WebKit Review Bot]

Comment on attachment 185948 [details]
Patch

Clearing flags on attachment: 185948

Committed r144935: <http://trac.webkit.org/changeset/144935>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.