Bug 108570

Summary:

[WK2] Use light supplement names instead of static AtomicStrings

Product:

WebKit

Reporter:

Benjamin Poulain <benjamin>

Component:

New Bugs

Assignee:

Benjamin Poulain <benjamin>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca, eric.carlson, feature-media-reviews, sam, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Benjamin Poulain 2013-01-31 20:50:54 PST

[WK2] Use light supplement names instead of static AtomicStrings

Comment 1 Benjamin Poulain 2013-01-31 20:54:17 PST

Created attachment 185925 [details]
Patch

Comment 2 Anders Carlsson 2013-02-01 11:37:25 PST

I like this!

How about we use the StringReference class instead - it's meant for storing a static string + length. It's currently inside the CoreIPC directory but we could move it out to Platform and use it for this as well (The advantage would be that we won't have to check string lengths).

Comment 3 Benjamin Poulain 2013-02-01 16:11:34 PST

Comment on attachment 185925 [details]
Patch

Clearing flags on attachment: 185925

Committed r141658: <http://trac.webkit.org/changeset/141658>

Comment 4 Benjamin Poulain 2013-02-01 16:11:36 PST

All reviewed patches have been landed.  Closing bug.