Bug 108569

Summary:

PrettyPatch/prettify.rb doesn't specify a load path for PrettyPatch.rb, & hard-codes the system ruby

Product:

WebKit

Reporter:

Nathan de Vries <ndevries>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Enhancement

CC:

dglazkov, joepeck, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Adds the directory containing prettify.rb to the $LOAD_PATH, and uses `env` to determine the ruby executable to use.	none
Patch without the commented out $LOAD_PATH push.	none

Nathan de Vries

Reported 2013-01-31 20:44:05 PST

You should be able to run prettify.rb from any working directory, and it shouldn't hard-code the system ruby path.

Attachments
Adds the directory containing prettify.rb to the $LOAD_PATH, and uses `env` to determine the ruby executable to use. (1.71 KB, patch) 2013-01-31 20:56 PST, Nathan de Vries	no flags	Details Formatted Diff Diff
Patch without the commented out $LOAD_PATH push. (1.71 KB, patch) 2013-01-31 21:08 PST, Nathan de Vries	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Nathan de Vries

Comment 1 2013-01-31 20:56:26 PST

Created attachment 185926 [details] Adds the directory containing prettify.rb to the $LOAD_PATH, and uses `env` to determine the ruby executable to use.

Joseph Pecoraro

Comment 2 2013-01-31 21:02:59 PST

Comment on attachment 185926 [details] Adds the directory containing prettify.rb to the $LOAD_PATH, and uses `env` to determine the ruby executable to use. View in context: https://bugs.webkit.org/attachment.cgi?id=185926&action=review > Websites/bugs.webkit.org/PrettyPatch/prettify.rb:7 > +#$LOAD_PATH << Pathname.new(__FILE__).dirname.realpath.to_s This looks commented out. Otherwise this looks good to me.

Nathan de Vries

Comment 3 2013-01-31 21:08:38 PST

Created attachment 185931 [details] Patch without the commented out $LOAD_PATH push.

WebKit Review Bot

Comment 4 2013-01-31 22:20:07 PST

Comment on attachment 185931 [details] Patch without the commented out $LOAD_PATH push. Attachment 185931 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16296320 New failing tests: fast/forms/datalist/update-range-with-datalist.html fast/layers/no-clipping-overflow-hidden-added-after-transform.html inspector-protocol/heap-profiler/heap-snapshot-with-detached-dom-tree.html fast/loader/text-document-wrapping.html fast/loader/javascript-url-in-object.html fast/layers/no-clipping-overflow-hidden-added-after-transition.html fast/layers/no-clipping-overflow-hidden-hardware-acceleration.html

Joseph Pecoraro

Comment 5 2013-02-01 13:49:49 PST

Comment on attachment 185931 [details] Patch without the commented out $LOAD_PATH push. r=me, test failures are unrelated

WebKit Review Bot

Comment 6 2013-02-01 14:47:49 PST

Comment on attachment 185931 [details] Patch without the commented out $LOAD_PATH push. Clearing flags on attachment: 185931 Committed r141646: <http://trac.webkit.org/changeset/141646>

WebKit Review Bot

Comment 7 2013-02-01 14:47:53 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.