Bug 108490

Summary:

Use ASSERT_WITH_SECURITY_IMPLICATION to catch bad casts in DOM

Product:

WebKit

Reporter:

Abhishek Arya <inferno>

Component:

DOM

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca, cmarcelo, commit-queue, dbarton, d-r, eric.carlson, eric, feature-media-reviews, fmalita, jamesr, mifenton, ojan.autocc, oliver, pdr, schenney, simon.fraser, tkent, tonikitoo, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Abhishek Arya

Reported 2013-01-31 09:10:18 PST

We have found numerous bugs (>12) after patch in http://trac.webkit.org/changeset/140640. This is another patch in sequence for dom nodes, css stuff.

Attachments
Patch (18.99 KB, patch) 2013-01-31 14:25 PST, Abhishek Arya	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Oliver Hunt

Comment 1 2013-01-31 10:46:30 PST

Can we get a bug that tracks all the bugs found by ASSERT_WITH_SECURITY_IMPLICATION?

Abhishek Arya

Comment 2 2013-01-31 10:58:39 PST

(In reply to comment #1) > Can we get a bug that tracks all the bugs found by ASSERT_WITH_SECURITY_IMPLICATION? Ok, starting to add "Depends on 107699" on those bugs. note that some bugs are filed in chromium repo are not upstreamed yet, i will do that in a day or two, just came back from a vacation :)

Abhishek Arya

Comment 3 2013-01-31 14:25:48 PST

Created attachment 185865 [details] Patch

Eric Seidel (no email)

Comment 4 2013-01-31 16:11:46 PST

Comment on attachment 185865 [details] Patch OK.

Eric Seidel (no email)

Comment 5 2013-01-31 16:12:14 PST

Have you documented in Assertions.h where/when these should be used? It's important that we do that so that other developers are not confused. :)

WebKit Review Bot

Comment 6 2013-01-31 17:41:04 PST

Comment on attachment 185865 [details] Patch Clearing flags on attachment: 185865 Committed r141516: <http://trac.webkit.org/changeset/141516>

WebKit Review Bot

Comment 7 2013-01-31 17:41:09 PST

All reviewed patches have been landed. Closing bug.

Abhishek Arya

Comment 8 2013-02-01 08:19:38 PST

(In reply to comment #5) > Have you documented in Assertions.h where/when these should be used? It's important that we do that so that other developers are not confused. :) Yes, there is a comment in there explaining the meaning and use of the assert. I plan to expand on the comment soon.

Note You need to log in before you can comment on or make changes to this bug.