Summary: | Add a watchlist message for WebKit2 OWNERS approval. | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mike West <mkwst> | ||||||
Component: | WebKit2 | Assignee: | Mike West <mkwst> | ||||||
Status: | ASSIGNED --- | ||||||||
Severity: | Normal | CC: | abarth, andersca, dpranke, eric, sam, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Mike West
2013-01-31 08:44:53 PST
Created attachment 185792 [details]
Patch
Created attachment 185793 [details]
Whitespace, my old nemesis.
Comment on attachment 185793 [details] Whitespace, my old nemesis. View in context: https://bugs.webkit.org/attachment.cgi?id=185793&action=review > Tools/Scripts/webkitpy/common/config/watchlist:461 > + "WebKit2OWNERS": [ "Please wait for approval from a member of the WebKit2 OWNERS file " > + "before submitting this patch, as it contains changes to WebKit2.", ], http://trac.webkit.org/browser/trunk/Source/WebKit2/Owners <--- Note that it's "Owners" rather than "OWNERS". (In reply to comment #3) > (From update of attachment 185793 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=185793&action=review > > > Tools/Scripts/webkitpy/common/config/watchlist:461 > > + "WebKit2OWNERS": [ "Please wait for approval from a member of the WebKit2 OWNERS file " > > + "before submitting this patch, as it contains changes to WebKit2.", ], > > http://trac.webkit.org/browser/trunk/Source/WebKit2/Owners <--- Note that it's "Owners" rather than "OWNERS". I'll fix that, thanks for the review. I'd appreciate someone on the Owners list weighing in here before I land this, however, since it affects how the change in process is presented to developers. I think the text is uncontroversial, but I'd like confirmation of that. :) |