Bug 108478

Summary:

Web Inspector: show cursor location in DTE

Product:

WebKit

Reporter:

Andrey Lushnikov <lushnikov>

Component:

Web Inspector (Deprecated)

Assignee:

Andrey Lushnikov <lushnikov>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

apavlov, keishi, loislo, pfeldman, pmuellr, vsevik, web-inspector-bugs, webkit.review.bot, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none
Patch	none
selection-multiline	none
selection of one line	none
cursor coordinates	none
Patch	none

Andrey Lushnikov

Reported 2013-01-31 06:48:48 PST

Show cursor location in DefaultTextEditor.

Attachments
Patch (5.33 KB, patch) 2013-01-31 06:56 PST, Andrey Lushnikov	no flags	Details Formatted Diff Diff
Patch (5.47 KB, patch) 2013-01-31 07:11 PST, Andrey Lushnikov	no flags	Details Formatted Diff Diff
selection-multiline (23.22 KB, image/png) 2013-01-31 07:11 PST, Andrey Lushnikov	no flags	Details
selection of one line (20.65 KB, image/png) 2013-01-31 07:11 PST, Andrey Lushnikov	no flags	Details
cursor coordinates (19.14 KB, image/png) 2013-01-31 07:12 PST, Andrey Lushnikov	no flags	Details
Patch (7.27 KB, patch) 2013-01-31 08:13 PST, Andrey Lushnikov	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Andrey Lushnikov

Comment 1 2013-01-31 06:56:15 PST

Created attachment 185773 [details] Patch

Pavel Feldman

Comment 2 2013-01-31 07:01:08 PST

Comment on attachment 185773 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=185773&action=review > Source/WebCore/inspector/front-end/SourceFrame.js:66 > + this._sourcePositionElement.addStyleClass("source-position"); .className = "source-frame-position" > Source/WebCore/inspector/front-end/SourceFrame.js:640 > + this._sourcePositionElement.textContent = "Line " + (textRange.endLine + 1) + ", Column " + (textRange.endColumn + 1); = WebInspector.UIString("Line %d, Column %d, line, column); > Source/WebCore/inspector/front-end/SourceFrame.js:647 > + text = (textRange.endLine - textRange.startLine + 1) + " lines, " + text; ditto

Andrey Lushnikov

Comment 3 2013-01-31 07:11:06 PST

Created attachment 185776 [details] Patch

Andrey Lushnikov

Comment 4 2013-01-31 07:11:34 PST

Created attachment 185777 [details] selection-multiline

Andrey Lushnikov

Comment 5 2013-01-31 07:11:56 PST

Created attachment 185778 [details] selection of one line

Andrey Lushnikov

Comment 6 2013-01-31 07:12:21 PST

Created attachment 185779 [details] cursor coordinates

Pavel Feldman

Comment 7 2013-01-31 08:05:36 PST

Comment on attachment 185776 [details] Patch Add them to localizedStrings.js

Andrey Lushnikov

Comment 8 2013-01-31 08:13:19 PST

Created attachment 185787 [details] Patch

WebKit Review Bot

Comment 9 2013-01-31 09:19:03 PST

Comment on attachment 185787 [details] Patch Clearing flags on attachment: 185787 Committed r141426: <http://trac.webkit.org/changeset/141426>

WebKit Review Bot

Comment 10 2013-01-31 09:19:07 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.