Bug 108474

Summary: [Qt] Enable QML handling of crashed/unresponsive QtWebProcess
Product: WebKit Reporter: Milian Wolff <milian.wolff>
Component: WebKit QtAssignee: Milian Wolff <milian.wolff>
Status: RESOLVED FIXED    
Severity: Normal CC: abecsi, allan.jensen, arurajku, cmarcelo, commit-queue, hepaajan, jturcotte, menard, michael.bruning, noam, svillar, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Milian Wolff
Reported 2013-01-31 06:09:42 PST
See also: https://lists.webkit.org/pipermail/webkit-qt/2013-January/003410.html Currently it is not possible to gracefully handle the case of a crashed/unresponsive QtWebProcess in WK2/QML. The idea is to add signals for that which would allow the QML developer to save any state that he might need, then trigger a reload and restore the old state or similar.
Attachments
Patch (7.09 KB, patch)
2013-01-31 06:30 PST, Milian Wolff 		no flags
DetailsFormatted DiffDiff
Patch (5.38 KB, patch)
2013-03-05 05:13 PST, Milian Wolff 		no flags
DetailsFormatted DiffDiff
Patch (4.66 KB, patch)
2013-07-31 10:55 PDT, Milian Wolff 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Milian Wolff
Comment 1 2013-01-31 06:30:12 PST
Created attachment 185771 [details] Patch
Michael Brüning
Comment 2 2013-03-05 02:23:18 PST
The patch in principal looks okay to me, however, it will have to be rewritten a bit because QtWebPageLoadClient no longer exists in that form, but has been folded into QQuickWebViewPrivate a while ago. Also, we might need to have a WebKit2 owner cc'ed for the sign off when the patch has been rewritten.
Milian Wolff
Comment 3 2013-03-05 05:13:26 PST
Created attachment 191471 [details] Patch
Milian Wolff
Comment 4 2013-03-28 08:48:22 PDT
Ping? Can we get this accepted please?
Jocelyn Turcotte
Comment 5 2013-07-30 03:43:39 PDT
Comment on attachment 191471 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=191471&action=review > Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:507 > + qWarning("WARNING: The web process has become unresponsive."); I think that this isn't necessary, it can be noisy for applications using the signals directly. > Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:514 > + qWarning("WARNING: The web process has become responsive."); Even less value for this one :) This looks good to me otherwise.
Milian Wolff
Comment 6 2013-07-31 10:55:23 PDT
Created attachment 207864 [details] Patch
WebKit Commit Bot
Comment 7 2013-08-01 04:05:27 PDT
Comment on attachment 207864 [details] Patch Clearing flags on attachment: 207864 Committed r153580: <http://trac.webkit.org/changeset/153580>
WebKit Commit Bot
Comment 8 2013-08-01 04:05:30 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.