Summary: | Web Inspector: [Profiles] show launcher view upon deleting last profile type's header | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Andrey Adaikin <aandrey> | ||||
Component: | Web Inspector (Deprecated) | Assignee: | Andrey Adaikin <aandrey> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | apavlov, keishi, loislo, pfeldman, pmuellr, vsevik, web-inspector-bugs, webkit.review.bot, yurys | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Andrey Adaikin
2013-01-31 05:22:10 PST
Created attachment 185759 [details]
Patch
Comment on attachment 185759 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=185759&action=review > Source/WebCore/inspector/front-end/ProfilesPanel.js:612 > + if (!sidebarParent.children.length) { Doesn't sidebarParent.children include section headers? (In reply to comment #2) > (From update of attachment 185759 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=185759&action=review > > > Source/WebCore/inspector/front-end/ProfilesPanel.js:612 > > + if (!sidebarParent.children.length) { > > Doesn't sidebarParent.children include section headers? Looks like it includes only WebInspector.ProfileSidebarTreeElement elements. Comment on attachment 185759 [details] Patch Clearing flags on attachment: 185759 Committed r141409: <http://trac.webkit.org/changeset/141409> All reviewed patches have been landed. Closing bug. |