Bug 108468 – Web Inspector: [Profiles] show launcher view upon deleting last profile type's header

• Component: Web Inspector (Deprecated)
• Status: RESOLVED FIXED

[Andrey Adaikin]

We should show launcher view and hide profile type sidebar section upon deleting last profile type's header from the sidebar. Right now we only show launcher view upon deleting the last profile header (of any profile type).

Patch to follow.

[Andrey Adaikin]

Created attachment 185759 [details]
Patch

[Yury Semikhatsky]

Comment on attachment 185759 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=185759&action=review

> Source/WebCore/inspector/front-end/ProfilesPanel.js:612
> +        if (!sidebarParent.children.length) {

Doesn't sidebarParent.children include section headers?

[Andrey Adaikin]

(In reply to comment #2)
> (From update of attachment 185759 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=185759&action=review
> 
> > Source/WebCore/inspector/front-end/ProfilesPanel.js:612
> > +        if (!sidebarParent.children.length) {
> 
> Doesn't sidebarParent.children include section headers?

Looks like it includes only WebInspector.ProfileSidebarTreeElement elements.

[WebKit Review Bot]

Comment on attachment 185759 [details]
Patch

Clearing flags on attachment: 185759

Committed r141409: <http://trac.webkit.org/changeset/141409>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.