| Summary: | [chromium] public methods and objects of TestRunner that are only used by the WebTestProxy should be private | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | jochen | ||||||||
| Component: | Tools / Tests | Assignee: | jochen | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | abarth, dglazkov, fishd, jamesr, tkent+wkapi, webkit.review.bot | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Bug Depends on: | |||||||||||
| Bug Blocks: | 91308 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
jochen
2013-01-31 05:21:13 PST
Created attachment 186347 [details]
Patch
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. Created attachment 186359 [details]
Patch
Comment on attachment 186359 [details]
Patch
Usually we prefer one patch per bug. (These patches are great btw!)
Comment on attachment 186347 [details] Patch Clearing flags on attachment: 186347 Committed r141785: <http://trac.webkit.org/changeset/141785> Comment on attachment 186359 [details] Patch Rejecting attachment 186359 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=gce-cq-04', 'apply-attachment', '--no-update', '--non-interactive', 186359, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue Last 500 characters of output: ebTestProxy.cpp.rej patching file Tools/DumpRenderTree/chromium/TestRunner/src/WebTestRunner.cpp rm 'Tools/DumpRenderTree/chromium/TestRunner/src/WebTestRunner.cpp' patching file Tools/DumpRenderTree/chromium/TestShell.h patching file Tools/DumpRenderTree/chromium/WebViewHost.cpp patching file Tools/DumpRenderTree/chromium/WebViewHost.h Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', '--force', '--reviewer', 'Adam Barth']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue Full output: http://queues.webkit.org/results/16378208 Created attachment 186459 [details]
Patch
Comment on attachment 186459 [details] Patch Clearing flags on attachment: 186459 Committed r141823: <http://trac.webkit.org/changeset/141823> All reviewed patches have been landed. Closing bug. |