Bug 108467

Summary:

[chromium] public methods and objects of TestRunner that are only used by the WebTestProxy should be private

Product:

WebKit

Reporter:

jochen

Component:

Tools / Tests

Assignee:

jochen

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, dglazkov, fishd, jamesr, tkent+wkapi, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

91308

Attachments:

Description	Flags
Patch	none
Patch	abarth: review+, webkit.review.bot: commit-queue-
Patch	none

jochen

Reported 2013-01-31 05:21:13 PST

That includes WebEventSender, WebAccessibilityController, WebTestPlugin, and a bunch of WebTestRunner methods

Attachments
Patch (63.49 KB, patch) 2013-02-04 04:28 PST, jochen	no flags	Details Formatted Diff Diff
Patch (43.26 KB, patch) 2013-02-04 05:48 PST, jochen	abarth: review+ webkit.review.bot: commit-queue-	Details Formatted Diff Diff
Patch (43.33 KB, patch) 2013-02-04 14:15 PST, jochen	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

jochen

Comment 1 2013-02-04 04:28:52 PST

Created attachment 186347 [details] Patch

WebKit Review Bot

Comment 2 2013-02-04 04:30:42 PST

Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.

jochen

Comment 3 2013-02-04 05:48:41 PST

Created attachment 186359 [details] Patch

Adam Barth

Comment 4 2013-02-04 09:34:23 PST

Comment on attachment 186359 [details] Patch Usually we prefer one patch per bug. (These patches are great btw!)

WebKit Review Bot

Comment 5 2013-02-04 11:00:37 PST

Comment on attachment 186347 [details] Patch Clearing flags on attachment: 186347 Committed r141785: <http://trac.webkit.org/changeset/141785>

WebKit Review Bot

Comment 6 2013-02-04 11:04:46 PST

Comment on attachment 186359 [details] Patch Rejecting attachment 186359 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=gce-cq-04', 'apply-attachment', '--no-update', '--non-interactive', 186359, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue Last 500 characters of output: ebTestProxy.cpp.rej patching file Tools/DumpRenderTree/chromium/TestRunner/src/WebTestRunner.cpp rm 'Tools/DumpRenderTree/chromium/TestRunner/src/WebTestRunner.cpp' patching file Tools/DumpRenderTree/chromium/TestShell.h patching file Tools/DumpRenderTree/chromium/WebViewHost.cpp patching file Tools/DumpRenderTree/chromium/WebViewHost.h Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', '--force', '--reviewer', 'Adam Barth']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue Full output: http://queues.webkit.org/results/16378208

jochen

Comment 7 2013-02-04 14:15:25 PST

Created attachment 186459 [details] Patch

WebKit Review Bot

Comment 8 2013-02-04 15:25:31 PST

Comment on attachment 186459 [details] Patch Clearing flags on attachment: 186459 Committed r141823: <http://trac.webkit.org/changeset/141823>

WebKit Review Bot

Comment 9 2013-02-04 15:25:35 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.