Bug 108443

Summary:

[V8] Clean up Dictionary::get() by removing redundant FindInstanceInPrototypeChain()

Product:

WebKit

Reporter:

Kentaro Hara <haraken>

Component:

WebCore JavaScript

Assignee:

Kentaro Hara <haraken>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, japhet, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Kentaro Hara 2013-01-31 01:16:29 PST

In Dictionary::get(), wrapper->FindInstanceInPrototypeChain(V8XXX::GetTemplate()) is unnecessary for DOM wrappers other than DOMWindow. For wrappers other than DOMWindow, we can simply use V8XXX::HasInstance(wrapper).

I'll clean up the code more by using template in a follow-up patch.

Comment 1 Kentaro Hara 2013-01-31 01:17:54 PST

Created attachment 185713 [details]
Patch

Comment 2 WebKit Review Bot 2013-01-31 17:13:56 PST

Comment on attachment 185713 [details]
Patch

Clearing flags on attachment: 185713

Committed r141509: <http://trac.webkit.org/changeset/141509>

Comment 3 WebKit Review Bot 2013-01-31 17:13:59 PST

All reviewed patches have been landed.  Closing bug.