Bug 108437

Summary:

Web Inspector: [CPU Profile] Apply minor refactorings and add JSDocs.

Product:

WebKit

Reporter:

Eugene Klyuchnikov <eustas>

Component:

Web Inspector (Deprecated)

Assignee:

Eugene Klyuchnikov <eustas>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

apavlov, caseq, eustas, keishi, loislo, pfeldman, pmuellr, vsevik, web-inspector-bugs, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	pfeldman: review+
Patch	none

Eugene Klyuchnikov

Reported 2013-01-30 23:56:07 PST

CPU Profile code has obsolete inline-comments to clarify types. Currently we use JSDocs to specify types. Also applied some minor refactorings.

Attachments
Patch (24.35 KB, patch) 2013-01-31 00:23 PST, Eugene Klyuchnikov	pfeldman: review+	Details Formatted Diff Diff
Patch (24.40 KB, patch) 2013-01-31 06:16 PST, Eugene Klyuchnikov	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Eugene Klyuchnikov

Comment 1 2013-01-31 00:23:44 PST

Pavel Feldman

Comment 2 2013-01-31 03:50:00 PST

Comment on attachment 185701 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=185701&action=review > Source/WebCore/inspector/front-end/BottomUpProfileDataGridTree.js:60 > + * Extra blank line we don't need.

Eugene Klyuchnikov

Comment 3 2013-01-31 06:10:47 PST

Comment on attachment 185701 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=185701&action=review >> Source/WebCore/inspector/front-end/BottomUpProfileDataGridTree.js:60 >> + * > > Extra blank line we don't need. Fixed.

Eugene Klyuchnikov

Comment 4 2013-01-31 06:16:38 PST

Andrey Kosyakov

Comment 5 2013-02-04 05:57:59 PST

Note You need to log in before you can comment on or make changes to this bug.