Bug 108436

Summary:

[V8] Trace not only major DOM GCs but also minor DOM GCs

Product:

WebKit

Reporter:

Kentaro Hara <haraken>

Component:

WebCore JavaScript

Assignee:

Kentaro Hara <haraken>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, japhet, nduca, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Kentaro Hara 2013-01-30 23:40:39 PST

Currently only major DOM GCs are traced. We should also trace minor DOM GCs.

Comment 1 Kentaro Hara 2013-01-30 23:41:44 PST

Created attachment 185688 [details]
Patch

Comment 2 Adam Barth 2013-01-31 00:04:06 PST

Comment on attachment 185688 [details]
Patch

TRACE_EVENT_BEGIN0 runs in release, right?  Does this impact the performance of minor GC?

Comment 3 Kentaro Hara 2013-01-31 00:07:50 PST

(In reply to comment #2)
> (From update of attachment 185688 [details])
> TRACE_EVENT_BEGIN0 runs in release, right?  Does this impact the performance of minor GC?

Yes, it runs in release. But when I measured the overhead of TRACE_EVENT(), it was less than 10 ns, which is ignorable for minor GCs.

Comment 4 Adam Barth 2013-01-31 00:11:18 PST

Thanks!

Comment 5 WebKit Review Bot 2013-01-31 00:54:31 PST

Comment on attachment 185688 [details]
Patch

Clearing flags on attachment: 185688

Committed r141390: <http://trac.webkit.org/changeset/141390>

Comment 6 WebKit Review Bot 2013-01-31 00:54:35 PST

All reviewed patches have been landed.  Closing bug.