Bug 108434

Summary: Rename WheelEvent::Granularity to WheelEvent::DeltaMode
Product: WebKit Reporter: Kentaro Hara <haraken>
Component: WebCore JavaScriptAssignee: Kentaro Hara <haraken>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, buildbot, ojan.autocc, philn, rniwa, sam, webkit-ews, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
patch for landing none

Kentaro Hara
Reported 2013-01-30 23:32:37 PST
Spec: https://dvcs.w3.org/hg/d4e/raw-file/tip/source_respec.htm#constructor-wheelevent In a follow-up patch I will implement a 'deltaMode' attribute.
Attachments
Patch (15.49 KB, patch)
2013-01-30 23:36 PST, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
patch for landing (10.52 KB, patch)
2013-01-31 00:26 PST, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2013-01-30 23:36:14 PST
Created attachment 185685 [details] Patch
Early Warning System Bot
Comment 2 2013-01-31 00:16:53 PST
Comment on attachment 185685 [details] Patch Attachment 185685 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/16283030
Build Bot
Comment 3 2013-01-31 00:18:41 PST
Comment on attachment 185685 [details] Patch Attachment 185685 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://queues.webkit.org/results/16271063
Ryosuke Niwa
Comment 4 2013-01-31 00:22:41 PST
Comment on attachment 185685 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=185685&action=review rs=me but please fix the build before you land it. > Source/WebCore/dom/WheelEvent.cpp:56 > + DeltaMode deltaMode, PassRefPtr<AbstractView> view, > + const IntPoint& screenLocation, const IntPoint& pageLocation, > + bool ctrlKey, bool altKey, bool shiftKey, bool metaKey, > + bool directionInvertedFromDevice) It seems like we can fit all of this in two lines if not one?
Kentaro Hara
Comment 5 2013-01-31 00:26:44 PST
Created attachment 185704 [details] patch for landing
Kentaro Hara
Comment 6 2013-01-31 00:27:27 PST
(In reply to comment #4) > (From update of attachment 185685 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=185685&action=review > > rs=me but please fix the build before you land it. Thanks! Will do. > It seems like we can fit all of this in two lines if not one? Done.
WebKit Review Bot
Comment 7 2013-01-31 03:12:17 PST
Comment on attachment 185704 [details] patch for landing Clearing flags on attachment: 185704 Committed r141394: <http://trac.webkit.org/changeset/141394>
WebKit Review Bot
Comment 8 2013-01-31 03:12:22 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.