Bug 108434

Summary: Rename WheelEvent::Granularity to WheelEvent::DeltaMode
Product: WebKit Reporter: Kentaro Hara <haraken>
Component: WebCore JavaScriptAssignee: Kentaro Hara <haraken>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, buildbot, ojan.autocc, philn, rniwa, sam, webkit-ews, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
patch for landing none

Description Kentaro Hara 2013-01-30 23:32:37 PST 
Spec: https://dvcs.w3.org/hg/d4e/raw-file/tip/source_respec.htm#constructor-wheelevent

In a follow-up patch I will implement a 'deltaMode' attribute.
Comment 1 Kentaro Hara 2013-01-30 23:36:14 PST 
Created attachment 185685 [details]
Patch
Comment 2 Early Warning System Bot 2013-01-31 00:16:53 PST 
Comment on attachment 185685 [details]
Patch

Attachment 185685 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/16283030
Comment 3 Build Bot 2013-01-31 00:18:41 PST 
Comment on attachment 185685 [details]
Patch

Attachment 185685 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://queues.webkit.org/results/16271063
Comment 4 Ryosuke Niwa 2013-01-31 00:22:41 PST 
Comment on attachment 185685 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=185685&action=review

rs=me but please fix the build before you land it.

> Source/WebCore/dom/WheelEvent.cpp:56
> +    DeltaMode deltaMode, PassRefPtr<AbstractView> view,
> +    const IntPoint& screenLocation, const IntPoint& pageLocation,
> +    bool ctrlKey, bool altKey, bool shiftKey, bool metaKey,
> +    bool directionInvertedFromDevice)

It seems like we can fit all of this in two lines if not one?
Comment 5 Kentaro Hara 2013-01-31 00:26:44 PST 
Created attachment 185704 [details]
patch for landing
Comment 6 Kentaro Hara 2013-01-31 00:27:27 PST 
(In reply to comment #4)
> (From update of attachment 185685 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=185685&action=review
> 
> rs=me but please fix the build before you land it.

Thanks! Will do.

> It seems like we can fit all of this in two lines if not one?

Done.
Comment 7 WebKit Review Bot 2013-01-31 03:12:17 PST 
Comment on attachment 185704 [details]
patch for landing

Clearing flags on attachment: 185704

Committed r141394: <http://trac.webkit.org/changeset/141394>
Comment 8 WebKit Review Bot 2013-01-31 03:12:22 PST 
All reviewed patches have been landed.  Closing bug.