Bug 108422 – REGRESSION(r141349): "yet another windows ews fix needed" (Requested by lforschler on #webkit).

• Component: New Bugs
• Status: NEW

[WebKit Review Bot]

http://trac.webkit.org/changeset/141349 broke the build:
"yet another windows ews fix needed" (Requested by lforschler on #webkit).

This is an automatic bug report generated by the sheriff-bot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests case pain.

"Only you can prevent forest fires." -- Smokey the Bear

[WebKit Review Bot]

Created attachment 185671 [details]
ROLLOUT of r141349

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID

where ATTACHMENT_ID is the ID of this attachment.

[Lucas Forschler]

build-dumprendertree is failing...  
Looks like we need to get that working before these will ever work.  DRT does build on our build slaves ok, so we need to find out what is missing/needed on the EWS bots.

Failed to run "['/home/buildbot/WebKit/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=APPLE-EWS-1', 'build-and-test', '--no-clean', '--no-update', '--test', '--non-interactive', '--port=win']" exit_code: 2 cwd: /home/buildbot/WebKit

Running run-webkit-tests
Failed to run "['Tools/Scripts/run-webkit-tests', '--no-new-test-results', '--no-show-results', '--exit-after-n-failures=30', '--quiet']" exit_code: 1

Running build-dumprendertree
Compiling DumpRenderTree failed!
Failed to execute Tools/Scripts/old-run-webkit-tests at Tools/Scripts/run-webkit-tests line 106.

Failed to run "['Tools/Scripts/run-webkit-tests', '--no-new-test-results', '--no-show-results', '--exit-after-n-failures=30', '--quiet']" exit_code: 1
Running build-dumprendertree
Compiling DumpRenderTree failed!
Failed to execute Tools/Scripts/old-run-webkit-tests at Tools/Scripts/run-webkit-tests line 106.

[Roger Fong]

Created attachment 185911 [details]
patch

Fix to make Win EWS bots go!
Again!

[Roger Fong]

I'm about to submit the patch anyways so I'll cq- the rollout

[Roger Fong]

Just kidding. The bots aren't in a good state for EWS right now. I'll need to clean that up first. CQ+ing the rollout

[WebKit Review Bot]

Comment on attachment 185671 [details]
ROLLOUT of r141349

Clearing flags on attachment: 185671

Committed r141522: <http://trac.webkit.org/changeset/141522>

[Roger Fong]

Can someone review this? Thanks

[Lucas Forschler]

Comment on attachment 185911 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=185911&action=review

> Scripts/webkitpy/tool/steps/runtests.py:93
> +            print self._options.build_style;

Is this in here for debugging?  You probably want to remove it if so.

[Roger Fong]

(In reply to comment #8)
> (From update of attachment 185911 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=185911&action=review
> 
> > Scripts/webkitpy/tool/steps/runtests.py:93
> > +            print self._options.build_style;
> 
> Is this in here for debugging?  You probably want to remove it if so.

Oh yeah, that won't be there.

[Lucas Forschler]

looks good to me.  I don't have reviewer privelidges.  But, you can land this manually with the print statement removed.

[Tim Horton]

Comment on attachment 185911 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=185911&action=review

> ChangeLog:8
> +        Disabling --quiet option on Windows for now because that fails when we try to use /dev/null.

You should fix this on the other end, but it's fine for now.

[Roger Fong]

http://trac.webkit.org/changeset/141628
Hoepfully that fixes all the issues