Bug 108418

Summary: PDFPlugin: Should respond to three-finger tap for dictionary definitions
Product: WebKit Reporter: Tim Horton <thorton>
Component: PDFAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, sam, simon.fraser
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch simon.fraser: review+

Description Tim Horton 2013-01-30 19:50:32 PST 
Have to snatch performDictionaryLookupAtLocation away from WebPageMac and route it through PDFLayerController.

<rdar://problem/13121409>
Comment 1 Tim Horton 2013-01-30 19:54:56 PST 
Created attachment 185661 [details]
patch
Comment 2 Simon Fraser (smfr) 2013-01-30 20:04:55 PST 
Comment on attachment 185661 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=185661&action=review

> Source/WebKit2/WebProcess/Plugins/PDF/PDFPlugin.mm:935
> +    if ([lookupSelection string] && [[lookupSelection string] isNotEqualTo:@""])

Better to test [[lookupSelection string] length], which you can do without null-checking [lookupSelection string]
Comment 3 Tim Horton 2013-01-30 21:04:04 PST 
http://trac.webkit.org/changeset/141372