Bug 108418

Summary: PDFPlugin: Should respond to three-finger tap for dictionary definitions
Product: WebKit Reporter: Tim Horton <thorton>
Component: PDFAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, sam, simon.fraser
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch simon.fraser: review+

Tim Horton
Reported 2013-01-30 19:50:32 PST
Have to snatch performDictionaryLookupAtLocation away from WebPageMac and route it through PDFLayerController. <rdar://problem/13121409>
Attachments
patch (9.09 KB, patch)
2013-01-30 19:54 PST, Tim Horton 		simon.fraser: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2013-01-30 19:54:56 PST
Created attachment 185661 [details] patch
Simon Fraser (smfr)
Comment 2 2013-01-30 20:04:55 PST
Comment on attachment 185661 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=185661&action=review > Source/WebKit2/WebProcess/Plugins/PDF/PDFPlugin.mm:935 > + if ([lookupSelection string] && [[lookupSelection string] isNotEqualTo:@""]) Better to test [[lookupSelection string] length], which you can do without null-checking [lookupSelection string]
Tim Horton
Comment 3 2013-01-30 21:04:04 PST
http://trac.webkit.org/changeset/141372
Note You need to log in before you can comment on or make changes to this bug.