Bug 108418 - PDFPlugin: Should respond to three-finger tap for dictionary definitions
Summary: PDFPlugin: Should respond to three-finger tap for dictionary definitions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: PDF (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-01-30 19:50 PST by Tim Horton
Modified: 2013-01-30 21:04 PST (History)
3 users (show)

See Also:

Attachments
patch (9.09 KB, patch)
2013-01-30 19:54 PST, Tim Horton 		simon.fraser: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2013-01-30 19:50:32 PST 
Have to snatch performDictionaryLookupAtLocation away from WebPageMac and route it through PDFLayerController.

<rdar://problem/13121409>
Comment 1 Tim Horton 2013-01-30 19:54:56 PST 
Created attachment 185661 [details]
patch
Comment 2 Simon Fraser (smfr) 2013-01-30 20:04:55 PST 
Comment on attachment 185661 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=185661&action=review

> Source/WebKit2/WebProcess/Plugins/PDF/PDFPlugin.mm:935
> +    if ([lookupSelection string] && [[lookupSelection string] isNotEqualTo:@""])

Better to test [[lookupSelection string] length], which you can do without null-checking [lookupSelection string]
Comment 3 Tim Horton 2013-01-30 21:04:04 PST 
http://trac.webkit.org/changeset/141372