Bug 108408

Summary: [chromium] Build webkit with enable_web_intents set to 0.
Product: WebKit Reporter: Nico Weber <thakis>
Component: New BugsAssignee: Nico Weber <thakis>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, haraken, japhet, jochen, ojan, peter+ews, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 108421    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Nico Weber
Reported 2013-01-30 17:30:09 PST
[chromium] Build webkit with enable_web_intents set to 0.
Attachments
Patch (5.02 KB, patch)
2013-01-30 17:31 PST, Nico Weber 		no flags
DetailsFormatted DiffDiff
Patch (10.89 KB, patch)
2013-01-31 12:06 PST, Nico Weber 		no flags
DetailsFormatted DiffDiff
Patch (10.98 KB, patch)
2013-01-31 14:18 PST, Nico Weber 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Nico Weber
Comment 1 2013-01-30 17:31:34 PST
Created attachment 185634 [details] Patch
Kentaro Hara
Comment 2 2013-01-30 17:40:46 PST
Comment on attachment 185634 [details] Patch LGTM
Kentaro Hara
Comment 3 2013-01-30 17:55:20 PST
(Although I think this is not controversial as this is just a chromium-only change, you might want to wait to cq+ the patch for one day to give folks a chance to comment on the webkit-dev@ thread.)
Adam Barth
Comment 4 2013-01-30 17:57:28 PST
Comment on attachment 185634 [details] Patch I don't think there's a need to wait to fix the build with ENABLE(WEB_INTENTS) off.
WebKit Review Bot
Comment 5 2013-01-30 18:19:08 PST
Comment on attachment 185634 [details] Patch Clearing flags on attachment: 185634 Committed r141358: <http://trac.webkit.org/changeset/141358>
WebKit Review Bot
Comment 6 2013-01-30 18:19:12 PST
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 7 2013-01-30 20:48:04 PST
Re-opened since this is blocked by bug 108421
Nico Weber
Comment 8 2013-01-31 12:06:41 PST
Created attachment 185833 [details] Patch
Nico Weber
Comment 9 2013-01-31 12:07:03 PST
Comment on attachment 185833 [details] Patch (still testing)
Nico Weber
Comment 10 2013-01-31 14:18:31 PST
Created attachment 185862 [details] Patch
Nico Weber
Comment 11 2013-01-31 14:19:26 PST
Ok, ptal. I checked that this now builds on android (with the dependent patch) and OS X. I won't land this before chromium deps have the dependency.
Peter Beverloo (cr-android ews)
Comment 12 2013-01-31 16:36:34 PST
Comment on attachment 185862 [details] Patch Attachment 185862 [details] did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/16300065
Peter Beverloo (cr-android ews)
Comment 13 2013-01-31 17:44:24 PST
Comment on attachment 185862 [details] Patch Attachment 185862 [details] did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/16305111
Nico Weber
Comment 14 2013-02-01 10:21:46 PST
Comment on attachment 185862 [details] Patch After r141537, this should hopefully build on android.
WebKit Review Bot
Comment 15 2013-02-01 11:15:37 PST
Comment on attachment 185862 [details] Patch Clearing flags on attachment: 185862 Committed r141614: <http://trac.webkit.org/changeset/141614>
WebKit Review Bot
Comment 16 2013-02-01 11:15:42 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.