Bug 108407

Summary: Add a call to the page UI client to determine if a plug-in should load
Product: WebKit Reporter: Brian Weinstein <bweinstein>
Component: WebKit2Assignee: Brian Weinstein <bweinstein>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, beidson, sam, webkit.review.bot
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch andersca: review+

Brian Weinstein
Reported 2013-01-30 17:23:35 PST
Add a call to the page UI client to determine if a plug-in should load <rdar://problem/13066332>
Attachments
Patch (15.60 KB, patch)
2013-01-31 13:41 PST, Brian Weinstein 		andersca: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brian Weinstein
Comment 1 2013-01-31 13:41:56 PST
Created attachment 185851 [details] Patch
WebKit Review Bot
Comment 2 2013-01-31 13:43:50 PST
Attachment 185851 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/UIProcess/API/C/WKPage.h', u'Source/WebKit2/UIProcess/WebPageProxy.cpp', u'Source/WebKit2/UIProcess/WebPageProxy.h', u'Source/WebKit2/UIProcess/WebPageProxy.messages.in', u'Source/WebKit2/UIProcess/WebProcessProxy.cpp', u'Source/WebKit2/UIProcess/WebProcessProxy.h', u'Source/WebKit2/UIProcess/WebProcessProxy.messages.in', u'Source/WebKit2/UIProcess/WebUIClient.cpp', u'Source/WebKit2/UIProcess/WebUIClient.h', u'Source/WebKit2/UIProcess/mac/WebInspectorProxyMac.mm', u'Source/WebKit2/WebProcess/WebPage/WebPage.cpp', u'Source/WebKit2/WebProcess/WebPage/WebPage.h', u'Tools/ChangeLog', u'Tools/MiniBrowser/mac/WK2BrowserWindowController.m', u'Tools/WebKitTestRunner/TestController.cpp']" exit_code: 1 Source/WebKit2/WebProcess/WebPage/WebPage.h:575: The parameter name "response" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebKit2/WebProcess/WebPage/WebPage.cpp:505: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] Total errors found: 2 in 13 files If any of these errors are false positives, please file a bug against check-webkit-style.
Brian Weinstein
Comment 3 2013-01-31 14:20:07 PST
Landed in r141486.
Note You need to log in before you can comment on or make changes to this bug.