Summary: | Disable process suppression of DumpRenderTree on Mac | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kiran Muppala <cmuppala> | ||||||
Component: | Tools / Tests | Assignee: | Kiran Muppala <cmuppala> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | dfarler, jberlin, webkit.review.bot | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=144308 | ||||||||
Attachments: |
|
Description
Kiran Muppala
2013-01-30 16:18:46 PST
Created attachment 185614 [details]
Patch
Comment on attachment 185614 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=185614&action=review > Tools/DumpRenderTree/mac/DumpRenderTree.mm:1443 > + reason:@"DumpRenderTree should not be subject to process suppression"]; Please do not use colon-aligning indentation. Subsequent lines should just use a 4 space indent. Also, you need a retain since beginSuspensionOfSystemBehaviors returns an autoreleased object. > Tools/DumpRenderTree/mac/DumpRenderTree.mm:1444 > + UNUSED_PARAM(assertion); You should use ASSERT_UNUSED instead. Created attachment 185626 [details]
Patch
(In reply to comment #3) > (From update of attachment 185614 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=185614&action=review > > > Tools/DumpRenderTree/mac/DumpRenderTree.mm:1443 > > + reason:@"DumpRenderTree should not be subject to process suppression"]; > > Please do not use colon-aligning indentation. Subsequent lines should just use a 4 space indent. > Fixed. > Also, you need a retain since beginSuspensionOfSystemBehaviors returns an autoreleased object. > > > Tools/DumpRenderTree/mac/DumpRenderTree.mm:1444 > > + UNUSED_PARAM(assertion); > > You should use ASSERT_UNUSED instead. Replaced with ASSERT_UNUSED. Comment on attachment 185626 [details] Patch Clearing flags on attachment: 185626 Committed r141353: <http://trac.webkit.org/changeset/141353> All reviewed patches have been landed. Closing bug. |