Bug 108400

Summary: Disable process suppression of DumpRenderTree on Mac
Product: WebKit Reporter: Kiran Muppala <cmuppala>
Component: Tools / TestsAssignee: Kiran Muppala <cmuppala>
Status: RESOLVED FIXED    
Severity: Normal CC: dfarler, jberlin, webkit.review.bot
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=144308
Attachments:
Description Flags
Patch
none
Patch none

Kiran Muppala
Reported 2013-01-30 16:18:46 PST
A lot of tests under animations are failing because DumpRenderTree is being process suppressed. A assertion must be taken to prevent this.
Attachments
Patch (1.57 KB, patch)
2013-01-30 16:27 PST, Kiran Muppala 		no flags
DetailsFormatted DiffDiff
Patch (1.49 KB, patch)
2013-01-30 16:58 PST, Kiran Muppala 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kiran Muppala
Comment 1 2013-01-30 16:18:59 PST
<rdar://problem/13115914>
Kiran Muppala
Comment 2 2013-01-30 16:27:14 PST
Created attachment 185614 [details] Patch
Jessie Berlin
Comment 3 2013-01-30 16:48:43 PST
Comment on attachment 185614 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=185614&action=review > Tools/DumpRenderTree/mac/DumpRenderTree.mm:1443 > + reason:@"DumpRenderTree should not be subject to process suppression"]; Please do not use colon-aligning indentation. Subsequent lines should just use a 4 space indent. Also, you need a retain since beginSuspensionOfSystemBehaviors returns an autoreleased object. > Tools/DumpRenderTree/mac/DumpRenderTree.mm:1444 > + UNUSED_PARAM(assertion); You should use ASSERT_UNUSED instead.
Kiran Muppala
Comment 4 2013-01-30 16:58:38 PST
Created attachment 185626 [details] Patch
Kiran Muppala
Comment 5 2013-01-30 16:59:07 PST
(In reply to comment #3) > (From update of attachment 185614 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=185614&action=review > > > Tools/DumpRenderTree/mac/DumpRenderTree.mm:1443 > > + reason:@"DumpRenderTree should not be subject to process suppression"]; > > Please do not use colon-aligning indentation. Subsequent lines should just use a 4 space indent. > Fixed. > Also, you need a retain since beginSuspensionOfSystemBehaviors returns an autoreleased object. > > > Tools/DumpRenderTree/mac/DumpRenderTree.mm:1444 > > + UNUSED_PARAM(assertion); > > You should use ASSERT_UNUSED instead. Replaced with ASSERT_UNUSED.
WebKit Review Bot
Comment 6 2013-01-30 18:08:48 PST
Comment on attachment 185626 [details] Patch Clearing flags on attachment: 185626 Committed r141353: <http://trac.webkit.org/changeset/141353>
WebKit Review Bot
Comment 7 2013-01-30 18:08:51 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.