Bug 108393

Summary: [BlackBerry] Bing Images viewport causes layout "fun"
Product: WebKit Reporter: Jacky Jiang <jkjiang>
Component: WebKit BlackBerryAssignee: Jacky Jiang <jkjiang>
Status: RESOLVED FIXED    
Severity: Normal CC: anilsson, manyoso, mifenton, rwlbuis, staikos, tonikitoo, webkit.review.bot, yong.li.webkit
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch yong.li.webkit: review+

Jacky Jiang
Reported 2013-01-30 15:41:24 PST
PR: 277855
Attachments
Patch (9.66 KB, patch)
2013-01-30 16:44 PST, Jacky Jiang 		no flags
DetailsFormatted DiffDiff
Patch (9.83 KB, patch)
2013-01-31 13:03 PST, Jacky Jiang 		yong.li.webkit: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jacky Jiang
Comment 1 2013-01-30 16:44:51 PST
Created attachment 185620 [details] Patch
Jacky Jiang
Comment 2 2013-01-31 13:03:47 PST
Created attachment 185844 [details] Patch
Yong Li
Comment 3 2013-01-31 13:18:51 PST
Comment on attachment 185844 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=185844&action=review > Source/WebCore/platform/blackberry/PlatformScreenBlackBerry.cpp:51 > +static FloatRect toUserSpace(FloatRect rect, Widget* widget) minor: 1. This function can be inline. 2. the null check for widget can be moved to this function
Jacky Jiang
Comment 4 2013-01-31 13:32:58 PST
(In reply to comment #3) > (From update of attachment 185844 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=185844&action=review > > > Source/WebCore/platform/blackberry/PlatformScreenBlackBerry.cpp:51 > > +static FloatRect toUserSpace(FloatRect rect, Widget* widget) > > minor: 1. This function can be inline. 2. the null check for widget can be moved to this function That function is just to be consistent with chromium port. Discussed with Yong, I can push it and may clean it in the future if we indeed want to do that.
Jacky Jiang
Comment 5 2013-01-31 14:00:30 PST
Committed r141481: <http://trac.webkit.org/changeset/141481>
Note You need to log in before you can comment on or make changes to this bug.