Bug 108381

Summary: [Chromium] WebPluginContainerImpl adding imbalanced touch handler refs
Product: WebKit Reporter: Levi Weintraub <leviw>
Component: Plug-insAssignee: Levi Weintraub <leviw>
Status: RESOLVED FIXED    
Severity: Normal CC: jamesr, jochen, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Levi Weintraub
Reported 2013-01-30 14:11:59 PST
Previously, WebPluginContainerImpl would call Document::didAddTouchEventHandler every time the plugin requested to receive touch events. When it's destructed, it only calls didRemoveTouchEventHandler once, leading to an imbalance. The fix here is to only call didAddTouchEventHandler once if touch events are requested.
Attachments
Patch (2.05 KB, patch)
2013-01-30 14:17 PST, Levi Weintraub 		no flags
DetailsFormatted DiffDiff
Patch (8.37 KB, patch)
2013-01-30 17:14 PST, Levi Weintraub 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Levi Weintraub
Comment 1 2013-01-30 14:17:07 PST
Created attachment 185568 [details] Patch
James Robinson
Comment 2 2013-01-30 14:22:07 PST
Comment on attachment 185568 [details] Patch We have a test plugin in Tools/DumpRenderTree/chromium/TestRunner/src/WebTestPlugin that can hit this API, any chance of a test?
Levi Weintraub
Comment 3 2013-01-30 14:23:43 PST
Let me take a look!
Levi Weintraub
Comment 4 2013-01-30 17:14:05 PST
Created attachment 185630 [details] Patch
Levi Weintraub
Comment 5 2013-01-30 17:26:20 PST
Comment on attachment 185630 [details] Patch Ty.
WebKit Review Bot
Comment 6 2013-01-30 18:16:35 PST
Comment on attachment 185630 [details] Patch Clearing flags on attachment: 185630 Committed r141357: <http://trac.webkit.org/changeset/141357>
WebKit Review Bot
Comment 7 2013-01-30 18:16:38 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.