Bug 108381

Summary: [Chromium] WebPluginContainerImpl adding imbalanced touch handler refs
Product: WebKit Reporter: Levi Weintraub <leviw>
Component: Plug-insAssignee: Levi Weintraub <leviw>
Status: RESOLVED FIXED    
Severity: Normal CC: jamesr, jochen, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Levi Weintraub 2013-01-30 14:11:59 PST 
Previously, WebPluginContainerImpl would call Document::didAddTouchEventHandler every time the plugin requested to receive touch events. When it's destructed, it only calls didRemoveTouchEventHandler once, leading to an imbalance. The fix here is to only call didAddTouchEventHandler once if touch events are requested.
Comment 1 Levi Weintraub 2013-01-30 14:17:07 PST 
Created attachment 185568 [details]
Patch
Comment 2 James Robinson 2013-01-30 14:22:07 PST 
Comment on attachment 185568 [details]
Patch

We have a test plugin in Tools/DumpRenderTree/chromium/TestRunner/src/WebTestPlugin that can hit this API, any chance of a test?
Comment 3 Levi Weintraub 2013-01-30 14:23:43 PST 
Let me take a look!
Comment 4 Levi Weintraub 2013-01-30 17:14:05 PST 
Created attachment 185630 [details]
Patch
Comment 5 Levi Weintraub 2013-01-30 17:26:20 PST 
Comment on attachment 185630 [details]
Patch

Ty.
Comment 6 WebKit Review Bot 2013-01-30 18:16:35 PST 
Comment on attachment 185630 [details]
Patch

Clearing flags on attachment: 185630

Committed r141357: <http://trac.webkit.org/changeset/141357>
Comment 7 WebKit Review Bot 2013-01-30 18:16:38 PST 
All reviewed patches have been landed.  Closing bug.