Bug 108374

Summary: Use OS() and PLATFORM() macros in WebCorePrefix.h for readability
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: New BugsAssignee: David Kilzer (:ddkilzer) <ddkilzer>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, bfulgham, darin, ddkilzer, laszlo.gombos, mjs, mrowe, sam, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch v1
none
Patch v1 with bug URL none

Description David Kilzer (:ddkilzer) 2013-01-30 13:23:03 PST 
Use OS() and PLATFORM() macros in WebCorePrefix.h for readability
Comment 1 David Kilzer (:ddkilzer) 2013-01-30 13:24:03 PST 
Created attachment 185548 [details]
Patch v1
Comment 2 WebKit Review Bot 2013-01-30 13:26:16 PST 
Attachment 185548 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/WebCorePrefix.h']" exit_code: 1
Source/WebCore/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 David Kilzer (:ddkilzer) 2013-01-30 13:27:59 PST 
I didn't replace __APPLE__ since I wasn't sure if we wanted OS(DARWIN) here or PLATFORM(APPLE) per discussion in Bug 108007.
Comment 4 David Kilzer (:ddkilzer) 2013-01-30 13:30:07 PST 
Created attachment 185549 [details]
Patch v1 with bug URL
Comment 5 Build Bot 2013-01-30 22:04:50 PST 
Comment on attachment 185549 [details]
Patch v1 with bug URL

Attachment 185549 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/16217980
Comment 6 David Kilzer (:ddkilzer) 2013-01-31 12:25:29 PST 
(In reply to comment #5)
> (From update of attachment 185549 [details])
> Attachment 185549 [details] did not pass win-ews (win):
> Output: http://queues.webkit.org/results/16217980

This seems bogus:

Running build-dumprendertree
Compiling DumpRenderTree failed!
Failed to execute Tools/Scripts/old-run-webkit-tests at Tools/Scripts/run-webkit-tests line 106.
Comment 7 Laszlo Gombos 2013-01-31 12:30:48 PST 
Comment on attachment 185549 [details]
Patch v1 with bug URL

lgtm.
Comment 8 WebKit Review Bot 2013-01-31 12:54:02 PST 
Comment on attachment 185549 [details]
Patch v1 with bug URL

Clearing flags on attachment: 185549

Committed r141468: <http://trac.webkit.org/changeset/141468>
Comment 9 WebKit Review Bot 2013-01-31 12:54:06 PST 
All reviewed patches have been landed.  Closing bug.