| Summary: | Add default implementation for KURL::fileSystemPath() | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Patrick R. Gansterer <paroga> | ||||||
| Component: | WebCore Misc. | Assignee: | Patrick R. Gansterer <paroga> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | dglazkov, gyuyoung.kim, mifenton, rakuco, rwlbuis, tonikitoo, webkit.review.bot, yong.li.webkit | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| Attachments: |
|
||||||||
|
Description
Patrick R. Gansterer
2013-01-30 04:39:05 PST
Created attachment 185467 [details]
Patch
Comment on attachment 185467 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=185467&action=review > Source/WebCore/platform/KURL.cpp:654 > + return path(); One common case where this would fail is for any path that has percent-encoded characters. I understand that this is just refactoring that doesn't change behavior for worse, however code in cross-platform files has a higher expectation of correctness than port-specific code. Created attachment 185692 [details]
Patch
Comment on attachment 185692 [details] Patch Attachment 185692 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16266160 New failing tests: fast/frames/parser-append-subframe-count.html Comment on attachment 185692 [details]
Patch
I am unhappy this adds more platform stuff in KURL.
This is a nice improvement nonetheless.
Committed r147883: <http://trac.webkit.org/changeset/147883> |