Bug 108325

Summary: [Qt][Win] r141177 broke the build
Product: WebKit Reporter: Zoltan Arvai <zarvai>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, bdakin, haraken, hausmann, jturcotte, webkit.review.bot, zeno
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 108244    
Attachments:
Description Flags
build fix none

Zoltan Arvai
Reported 2013-01-30 04:13:45 PST
First r141174 broke the build, but r141203 fixed some of the issues. After that r141177 broke Win build by removing MessageID methods. Current build log: C:\WebKitBuildSlave\szeged-windows-1\qt-windows-32bit-release\build\Source\WebKit2\Platform\CoreIPC\win\ConnectionWin.cpp(176) : error C2039: 'fromInt' : is not a member of 'CoreIPC::MessageID' c:\webkitbuildslave\szeged-windows-1\qt-windows-32bit-release\build\source\webkit2\platform\coreipc\MessageID.h(162) : see declaration of 'CoreIPC::MessageID' C:\WebKitBuildSlave\szeged-windows-1\qt-windows-32bit-release\build\Source\WebKit2\Platform\CoreIPC\win\ConnectionWin.cpp(176) : error C3861: 'fromInt': identifier not found C:\WebKitBuildSlave\szeged-windows-1\qt-windows-32bit-release\build\Source\WebKit2\Platform\CoreIPC\win\ConnectionWin.cpp(291) : error C2039: 'toInt' : is not a member of 'CoreIPC::MessageID' c:\webkitbuildslave\szeged-windows-1\qt-windows-32bit-release\build\source\webkit2\platform\coreipc\MessageID.h(162) : see declaration of 'CoreIPC::MessageID'
Attachments
build fix (1.84 KB, patch)
2013-01-30 07:14 PST, Zoltan Arvai 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Zoltan Arvai
Comment 1 2013-01-30 07:14:10 PST
Created attachment 185500 [details] build fix This build fix created based on the patch in https://bugs.webkit.org/show_bug.cgi?id=108244 Is it a valid solution for the problem? Builds with MSVC.
Zoltan Arvai
Comment 2 2013-01-30 10:10:09 PST
Please review the fix to get Qt Windows bot's build working again.
WebKit Review Bot
Comment 3 2013-01-30 11:14:18 PST
Comment on attachment 185500 [details] build fix Clearing flags on attachment: 185500 Committed r141287: <http://trac.webkit.org/changeset/141287>
WebKit Review Bot
Comment 4 2013-01-30 11:14:22 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.