Bug 10832 – Webkit WebCore build fails on Windows.

• Component: WebCore Misc.
• Status: RESOLVED FIXED

[Karthik Kumar]

Apparently in {$WebKit}/WebCore/bindings/scripts/CodeGenerator.pm, Line 211:

 $thisDir = "$ENV{SOURCE_ROOT}/$directory";

breaks. The only real way to fix it is to change it to:

 $thisDir = "/cygdrive/c/Webkit/WebCore/$directory";

 (or some other absolute path)

or change the cygwin config (.bashrc) and set the variable.

Setting too many messy environmental variables is also hard. 

Suggestions: 

1. Please make the script get the current directory and scan in it.
2. Use basename of the target idl file to be scanned and scan in it.
3. Re-document the build procedure.

[Mark Rowe (bdash)]

This is also broken on the Windows build slave.  SOURCE_ROOT appears to be automagically set from Xcode, so it is not available on Windows without the user manually setting it.  IMO the path should be derived from the absolute path to the script being executed (similar to point 2 in Karthik's comment).

[Mark Rowe (bdash)]

The use of SOURCE_ROOT was introduced in r16342 (http://trac.webkit.org/projects/webkit/changeset/16342).

[Adam Roben (:aroben)]

Why not just set SOURCE_ROOT in build-generated-files.sh?

[Darin Fisher (:fishd, Google)]

Created attachment 10537 [details]
patch

[Adam Roben (:aroben)]

Comment on attachment 10537 [details]
patch

r=me

[Adam Roben (:aroben)]

Comment on attachment 10537 [details]
patch

Landed as r16345.