| Summary: | [Qt] Fix Qt/Mac build after r141024 and r141037 | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Zeno Albisser <zeno> | ||||||
| Component: | New Bugs | Assignee: | Zeno Albisser <zeno> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | benjamin, haraken, ojan.autocc, webkit.review.bot, zarvai | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Zeno Albisser
2013-01-30 02:45:56 PST
Created attachment 185450 [details]
Patch
Comment on attachment 185450 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=185450&action=review rs=me > Source/WTF/ChangeLog:3 > + [Qt] Fix Qt/Mac build after r141024 I think this error would be due to r141037. *** Bug 108321 has been marked as a duplicate of this bug. *** Comment on attachment 185450 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=185450&action=review >> Source/WTF/ChangeLog:3 >> + [Qt] Fix Qt/Mac build after r141024 > > I think this error would be due to r141037. It is failing on the bot since r141024. But it is likely that the patch fixes more than a "single" breakage. So I'll update the title to mention both revisions. I will have to re-upload the patch again, because there are two more PLATFORM(MAC) that need to be replaced with OS(DARWIN) in Functional.h. - Sorry for the inconvenience. Created attachment 185471 [details]
Patch
Comment on attachment 185471 [details]
Patch
rs=me
Comment on attachment 185471 [details] Patch Clearing flags on attachment: 185471 Committed r141263: <http://trac.webkit.org/changeset/141263> All reviewed patches have been landed. Closing bug. |