Bug 108273

Summary:

Remove use of plugInStartLabelImage

Product:

WebKit

Reporter:

Dean Jackson <dino>

Component:

Plug-ins

Assignee:

Dean Jackson <dino>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, dglazkov, jonlee, peter+ews, philn, rniwa, simon.fraser, tkent, webkit-bug-importer, webkit-ews, webkit.review.bot, xan.lopez

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

108284

Bug Blocks:

Attachments:

Description	Flags
Patch	simon.fraser: review+, webkit-ews: commit-queue-

Dean Jackson

Reported 2013-01-29 17:56:39 PST

When snapshotted plugins start using a shadow root, they won't need this code.

Attachments
Patch (10.93 KB, patch) 2013-01-29 18:10 PST, Dean Jackson	simon.fraser: review+ webkit-ews: commit-queue-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2013-01-29 17:56:49 PST

<rdar://problem/13112117>

Dean Jackson

Comment 2 2013-01-29 18:10:05 PST

Created attachment 185365 [details] Patch

Jon Lee

Comment 3 2013-01-29 18:16:44 PST

Unofficial r=me.

Early Warning System Bot

Comment 4 2013-01-29 18:17:35 PST

Comment on attachment 185365 [details] Patch Attachment 185365 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/16200403

Simon Fraser (smfr)

Comment 5 2013-01-29 18:19:34 PST

Comment on attachment 185365 [details] Patch r=me but please fix Qt.

Dean Jackson

Comment 6 2013-01-29 18:24:38 PST

I think all EWS will fail because this is removing code that is still being called in the tree (subsequent patch). I'll stage this commit later, and check EWS first.

Build Bot

Comment 7 2013-01-29 18:39:35 PST

Comment on attachment 185365 [details] Patch Attachment 185365 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://queues.webkit.org/results/16115490

WebKit Review Bot

Comment 8 2013-01-29 19:05:40 PST

Comment on attachment 185365 [details] Patch Attachment 185365 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16199410

Peter Beverloo (cr-android ews)

Comment 9 2013-01-29 19:20:26 PST

Comment on attachment 185365 [details] Patch Attachment 185365 [details] did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/16217258

Build Bot

Comment 10 2013-01-29 19:26:26 PST

Comment on attachment 185365 [details] Patch Attachment 185365 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/16022528