Bug 108224

Summary:

BUILD FIX: Make WebCorePrefix.h build on iOS

Product:

WebKit

Reporter:

David Kilzer (:ddkilzer) <ddkilzer>

Component:

WebCore Misc.

Assignee:

David Kilzer (:ddkilzer) <ddkilzer>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, darin, mrowe, sam, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

David Kilzer (:ddkilzer)

Reported 2013-01-29 13:48:15 PST

<http://webkit.org/b/000000> Reviewed by NOBODY (OOPS!). * WebCorePrefix.h: - Include <wtf/Platform.h>. - Do not include <CoreServices/CoreServices.h> on iOS. - Include <Foundation/Foundation.h> instead of <Cocoa/Cocoa.h> on iOS. --- 2 files changed, 23 insertions(+), 2 deletions(-)

Attachments
Patch (1.90 KB, patch) 2013-01-29 13:48 PST, David Kilzer (:ddkilzer)	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

David Kilzer (:ddkilzer)

Comment 1 2013-01-29 13:48:16 PST

Created attachment 185301 [details] Patch

David Kilzer (:ddkilzer)

Comment 2 2013-01-29 13:52:13 PST

Was Platform.h not included in WebCorePrefix.h for a reason? (Maybe to force config.h to be included in all source files, or to prevent ENABLE(), USE(), PLATFORM(), etc. macros from appearing in headers?)

WebKit Review Bot

Comment 3 2013-01-30 04:23:01 PST

Comment on attachment 185301 [details] Patch Clearing flags on attachment: 185301 Committed r141254: <http://trac.webkit.org/changeset/141254>

WebKit Review Bot

Comment 4 2013-01-30 04:23:04 PST

All reviewed patches have been landed. Closing bug.

David Kilzer (:ddkilzer)

Comment 5 2013-01-30 10:28:10 PST

(In reply to comment #2) > Was Platform.h not included in WebCorePrefix.h for a reason? (Maybe to force config.h to be included in all source files, or to prevent ENABLE(), USE(), PLATFORM(), etc. macros from appearing in headers?) Note that the Tools/Scripts/check-for-inappropriate-macros-in-external-headers script now checks for those macros appearing in public headers.

Note You need to log in before you can comment on or make changes to this bug.