Summary: | Add RenderLayer::enclosingStackingContainer | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | vollick | ||||
Component: | WebCore Misc. | Assignee: | vollick | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | eric, ojan.autocc, simon.fraser, sugoi, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
vollick
2013-01-29 11:54:12 PST
Created attachment 185279 [details]
Patch
Comment on attachment 185279 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=185279&action=review > Source/WebCore/rendering/RenderLayer.h:446 > + RenderLayer* enclosingStackingContainer() { return isStackingContainer() ? this : stackingContainer(); } Should be const. I should mention for folks not following #webkit, the reason I'd gone ahead and cq+'d the patch was because making enclosingStackingContainer const would prevent me from returning 'this' as a non-const RenderLayer*. Going with the patch as-is was the consensus in the channel. Comment on attachment 185279 [details] Patch Rejecting attachment 185279 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=gce-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 185279, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue Last 500 characters of output: rce/WebKit/chromium/webkit/media/crypto/ppapi/cdm --revision 173055 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' 56>At revision 173055. ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/16202287 Comment on attachment 185279 [details] Patch Clearing flags on attachment: 185279 Committed r141159: <http://trac.webkit.org/changeset/141159> All reviewed patches have been landed. Closing bug. |