Bug 108191

Summary: Consolidate the way WTF_USE_PTHREADS is enabled
Product: WebKit Reporter: Laszlo Gombos <laszlo.gombos>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, benjamin, cmarcelo, eric, gyuyoung.kim, ojan.autocc, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
cleanup
benjamin: review+, benjamin: commit-queue-
for cq none

Laszlo Gombos
Reported 2013-01-29 07:04:23 PST
It seems to me that WTF_USE_PTHREADS can be defined with the following simple rule in Platform.h: #if OS(UNIX) #define WTF_USE_PTHREADS 1 #endif Currently we have various other means (at last count 8 - some in port specific build systems) to enable WTF_USE_PTHREADS for the various build configurations.
Attachments
cleanup (3.86 KB, patch)
2013-02-03 04:58 PST, Laszlo Gombos 		benjamin: review+
benjamin: commit-queue-
DetailsFormatted DiffDiff
for cq (4.15 KB, patch)
2013-02-10 08:49 PST, Laszlo Gombos 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Laszlo Gombos
Comment 1 2013-02-03 04:58:56 PST
Created attachment 186260 [details] cleanup
Build Bot
Comment 2 2013-02-03 07:19:56 PST
Comment on attachment 186260 [details] cleanup Attachment 186260 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/16346687
Build Bot
Comment 3 2013-02-03 08:06:57 PST
Comment on attachment 186260 [details] cleanup Attachment 186260 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/16346711
Laszlo Gombos
Comment 4 2013-02-05 12:33:34 PST
(In reply to comment #3) > (From update of attachment 186260 [details]) > Attachment 186260 [details] did not pass win-ews (win): > Output: http://queues.webkit.org/results/16346711 This seems to be an unrelated failure, removing cq-.
Benjamin Poulain
Comment 5 2013-02-05 13:10:02 PST
Comment on attachment 186260 [details] cleanup View in context: https://bugs.webkit.org/attachment.cgi?id=186260&action=review > Source/WTF/wtf/Platform.h:668 > +#if OS(UNIX) > #define WTF_USE_PTHREADS 1 > #endif Instead, consolidate the OS(UNIX) section. Remove this one and move WTF_USE_PTHREADS to the existing section.
Laszlo Gombos
Comment 6 2013-02-10 08:49:33 PST
Created attachment 187481 [details] for cq
WebKit Review Bot
Comment 7 2013-02-10 13:05:38 PST
Comment on attachment 187481 [details] for cq Clearing flags on attachment: 187481 Committed r142417: <http://trac.webkit.org/changeset/142417>
WebKit Review Bot
Comment 8 2013-02-10 13:05:43 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.