Bug 108188
| Summary: | [WIN] Use CF to format date | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Laszlo Gombos <laszlo.gombos> |
| Component: | Platform | Assignee: | Brent Fulgham <bfulgham> |
| Status: | RESOLVED CONFIGURATION CHANGED | ||
| Severity: | Normal | CC: | ahmad.saleem792, bfulgham, ddkilzer, fujii.hironori, oliver |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Laszlo Gombos
CF is belied to be superior to the strftime-based version. Consider using CF to format date on Windows as well.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Laszlo Gombos
See the FIXME in JavaScriptCore/runtime/DatePrototype.cpp and the discussion at bug 107406 .
Brent Fulgham
I assume the FIXME you refer to is:
static const int yearLen = 5; // FIXME will be a problem in the year 10,000
:-)
Brent Fulgham
I agree with this patch in principle. I think the set of tests would be better handled as a "USE(CF)", since that seems to be what the current logic is attempting to do.
The only thing I am unsure of is whether there is any performance impact to making this change. Maybe one of the JavaScriptCore experts could let us know if this might be an issue. It seems unlikely that this would be a problem.
Ahmad Saleem
I am unable to find this FIXME and was this specific to AppleWin port or win-cairo was also impacted and whether we need to do anything?
@Brent & @Fuji - any input?
Brent Fulgham
This is no longer relevant. The modern Windows ports no longer use CoreFoundation or CFLite.