Bug 108185

Summary: Canvas support for isPointInStroke
Product: WebKit Reporter: Dirk Schulze <krit>
Component: CanvasAssignee: Dirk Schulze <krit>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, dino, ojan.autocc, oliver, simon.fraser, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
URL: https://bugzilla.mozilla.org/show_bug.cgi?id=803124
Attachments:
Description Flags
Patch
none
Patch dino: review+

Dirk Schulze
Reported 2013-01-29 05:35:24 PST
Firefox implemented isPointInStroke unprefixed. We should do the same, since this seems to be a really useful function. See link to Firefox bug report.
Attachments
Patch (12.35 KB, patch)
2013-01-29 05:48 PST, Dirk Schulze 		no flags
DetailsFormatted DiffDiff
Patch (13.24 KB, patch)
2013-01-29 07:09 PST, Dirk Schulze 		dino: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dirk Schulze
Comment 1 2013-01-29 05:48:46 PST
Created attachment 185227 [details] Patch
WebKit Review Bot
Comment 2 2013-01-29 06:52:54 PST
Comment on attachment 185227 [details] Patch Attachment 185227 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16183173 New failing tests: inspector/profiler/canvas2d/canvas2d-api-changes.html
Dirk Schulze
Comment 3 2013-01-29 07:09:10 PST
Created attachment 185236 [details] Patch
Dean Jackson
Comment 4 2013-01-29 09:55:05 PST
Comment on attachment 185236 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=185236&action=review > Source/WebCore/ChangeLog:12 > + Firfox implemented isPointInStroke originaly and unprefixed it recently: Typos: Firefox and originally > Source/WebCore/ChangeLog:20 > + (WebCore): I really should submit a patch to prepareChangeLog so that it doesn't spit out these useless lines. In this case, I think the change in the comment triggered it.
Dirk Schulze
Comment 5 2013-01-29 12:28:27 PST
Committed r141141: <http://trac.webkit.org/changeset/141141>
Note You need to log in before you can comment on or make changes to this bug.