Bug 108181

Summary: Web Inspector: Change the Elements panel sidebar layout based on its aspect ratio.
Product: WebKit Reporter: Vladislav Kaznacheev <kaznacheev>
Component: Web Inspector (Deprecated)Assignee: Vladislav Kaznacheev <kaznacheev>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, keishi, levin+threading, loislo, pfeldman, pmuellr, vsevik, web-inspector-bugs, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Vladislav Kaznacheev
Reported 2013-01-29 05:08:04 PST
A followup to https://bugs.webkit.org/show_bug.cgi?id=107129. The sidebar layout should depend on the sidebar aspect ratio, not the docking mode.
Attachments
Patch (9.51 KB, patch)
2013-01-29 05:16 PST, Vladislav Kaznacheev 		no flags
DetailsFormatted DiffDiff
Patch (18.00 KB, patch)
2013-01-30 01:01 PST, Vladislav Kaznacheev 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Vladislav Kaznacheev
Comment 1 2013-01-29 05:16:02 PST
Created attachment 185220 [details] Patch
Pavel Feldman
Comment 2 2013-01-29 07:07:15 PST
Comment on attachment 185220 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=185220&action=review > Source/WebCore/inspector/front-end/SidebarView.js:66 > + Start: "Start", Why would we need Left, Right, Top and Bottom then? Start/End + orientation uniquely identify it.
Vladislav Kaznacheev
Comment 3 2013-01-30 01:01:22 PST
Created attachment 185421 [details] Patch
WebKit Review Bot
Comment 4 2013-01-30 04:01:16 PST
Comment on attachment 185421 [details] Patch Clearing flags on attachment: 185421 Committed r141249: <http://trac.webkit.org/changeset/141249>
WebKit Review Bot
Comment 5 2013-01-30 04:01:21 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.