Bug 108161 – Web Inspector: introduce HighlightDescriptor interface in DTE.

• Component: Web Inspector (Deprecated)
• Status: RESOLVED FIXED

[Andrey Lushnikov]

Introduce HighlightDescriptor interface and refactor highlight regex implementation to use RegexHighlightDescriptor class. 
This will make it possible to add "highlight range" functionality easily in future.

[Andrey Lushnikov]

Created attachment 185185 [details]
Patch

[Pavel Feldman]

Comment on attachment 185185 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=185185&action=review

> Source/WebCore/inspector/front-end/DefaultTextEditor.js:1379
> +        this._highlightDescriptors[regex] = highlightDescriptor;

Now you should simply store it in the array.

> Source/WebCore/inspector/front-end/DefaultTextEditor.js:1389
> +        var result = delete this._highlightDescriptors[regex];

... and remove it by instance.

> Source/WebCore/inspector/front-end/DefaultTextEditor.js:2661
> +    testLine: function(lineNumber, line) { return false; },

Consider renaming - I can't tell what it does from its name.

[Andrey Lushnikov]

Created attachment 185216 [details]
Patch

[Pavel Feldman]

Comment on attachment 185216 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=185216&action=review

> Source/WebCore/inspector/front-end/DefaultTextEditor.js:1375
> +     * @regex {WebInspector.TextEditorMainPanel.HighlightDescriptor}

@return

[Andrey Lushnikov]

Created attachment 185244 [details]
Patch

[WebKit Review Bot]

Comment on attachment 185244 [details]
Patch

Clearing flags on attachment: 185244

Committed r141111: <http://trac.webkit.org/changeset/141111>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.