Bug 108161

Summary: Web Inspector: introduce HighlightDescriptor interface in DTE.
Product: WebKit Reporter: Andrey Lushnikov <lushnikov>
Component: Web Inspector (Deprecated)Assignee: Andrey Lushnikov <lushnikov>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, keishi, loislo, pfeldman, pmuellr, vsevik, web-inspector-bugs, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Andrey Lushnikov 2013-01-29 00:26:26 PST 
Introduce HighlightDescriptor interface and refactor highlight regex implementation to use RegexHighlightDescriptor class. 
This will make it possible to add "highlight range" functionality easily in future.
Comment 1 Andrey Lushnikov 2013-01-29 00:31:25 PST 
Created attachment 185185 [details]
Patch
Comment 2 Pavel Feldman 2013-01-29 02:50:12 PST 
Comment on attachment 185185 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=185185&action=review

> Source/WebCore/inspector/front-end/DefaultTextEditor.js:1379
> +        this._highlightDescriptors[regex] = highlightDescriptor;

Now you should simply store it in the array.

> Source/WebCore/inspector/front-end/DefaultTextEditor.js:1389
> +        var result = delete this._highlightDescriptors[regex];

... and remove it by instance.

> Source/WebCore/inspector/front-end/DefaultTextEditor.js:2661
> +    testLine: function(lineNumber, line) { return false; },

Consider renaming - I can't tell what it does from its name.
Comment 3 Andrey Lushnikov 2013-01-29 04:08:05 PST 
Created attachment 185216 [details]
Patch
Comment 4 Pavel Feldman 2013-01-29 04:27:05 PST 
Comment on attachment 185216 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=185216&action=review

> Source/WebCore/inspector/front-end/DefaultTextEditor.js:1375
> +     * @regex {WebInspector.TextEditorMainPanel.HighlightDescriptor}

@return
Comment 5 Andrey Lushnikov 2013-01-29 07:30:14 PST 
Created attachment 185244 [details]
Patch
Comment 6 WebKit Review Bot 2013-01-29 07:53:34 PST 
Comment on attachment 185244 [details]
Patch

Clearing flags on attachment: 185244

Committed r141111: <http://trac.webkit.org/changeset/141111>
Comment 7 WebKit Review Bot 2013-01-29 07:53:38 PST 
All reviewed patches have been landed.  Closing bug.