Summary: | webdatabase: Change DatabaseManager interface to be static methods. | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mark Lam <mark.lam> | ||||
Component: | WebCore Misc. | Assignee: | Mark Lam <mark.lam> | ||||
Status: | ASSIGNED --- | ||||||
Severity: | Normal | CC: | abarth, gyuyoung.kim, japhet, mark.lam, mifenton, rakuco, rwlbuis, sam, tonikitoo, webkit.review.bot, yong.li.webkit | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Mark Lam
2013-01-28 19:45:46 PST
Created attachment 185139 [details]
the patch.
This patch is mostly cosmetic. I basically moved the DatabaseManager implementation to an Internal class, and reimplemented DatabaseManager methods as static which forwards the call to the Internal instance.
This patch was rs= Sam Weinig.
Comment on attachment 185139 [details] the patch. Attachment 185139 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/16163938 This turned out to be harder than I originally thought. The Windows port does not think that DatabaseManager's "friend"-ship extends to DatabaseManager::Internal. Since, this effort is turning hairy (it was supposed to be a slam dunk), I'll postpone it. The implementation of DatabaseManager will shift in the near future. I might be able to make this change with minimal effort then. I'll leave it be for now. |