| Summary: | [Qt] Build fix | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jae Hyun Park <jaepark> | ||||||||||||
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | abecsi, cmarcelo, menard, webkit.review.bot | ||||||||||||
| Priority: | P2 | ||||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||||
| Hardware: | Unspecified | ||||||||||||||
| OS: | Unspecified | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Jae Hyun Park
2013-01-28 18:16:03 PST
Created attachment 185126 [details]
Patch
Created attachment 185128 [details]
Patch
Comment on attachment 185128 [details]
Patch
rs=me
Created attachment 185140 [details]
Patch for landing
Created attachment 185155 [details]
Patch for landing
I made a mistake and omitted to add UIProcess/Storage into INCLUDEPATH. The last patch fixes the build correctly. Comment on attachment 185155 [details] Patch for landing Rejecting attachment 185155 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=gce-cq-02', 'validate-changelog', '--non-interactive', 185155, '--port=chromium-xvfb']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue /mnt/git/webkit-commit-queue/Source/WebKit2/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/16196006 Created attachment 185170 [details]
Patch
Comment on attachment 185170 [details] Patch Clearing flags on attachment: 185170 Committed r141068: <http://trac.webkit.org/changeset/141068> All reviewed patches have been landed. Closing bug. |