Bug 108142

Summary: [Qt] Build fix
Product: WebKit Reporter: Jae Hyun Park <jaepark>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abecsi, cmarcelo, menard, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing
none
Patch for landing
none
Patch none

Jae Hyun Park
Reported 2013-01-28 18:16:03 PST
StorageManager is not included in Target.pri and CMakeLists.txt
Attachments
Patch (2.42 KB, patch)
2013-01-28 18:21 PST, Jae Hyun Park 		no flags
DetailsFormatted DiffDiff
Patch (1.57 KB, patch)
2013-01-28 18:27 PST, Jae Hyun Park 		no flags
DetailsFormatted DiffDiff
Patch for landing (1.57 KB, patch)
2013-01-28 20:08 PST, Jae Hyun Park 		no flags
DetailsFormatted DiffDiff
Patch for landing (2.10 KB, patch)
2013-01-28 22:23 PST, Jae Hyun Park 		no flags
DetailsFormatted DiffDiff
Patch (2.08 KB, patch)
2013-01-28 23:10 PST, Jae Hyun Park 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Jae Hyun Park
Comment 1 2013-01-28 18:21:36 PST
Created attachment 185126 [details] Patch
Jae Hyun Park
Comment 2 2013-01-28 18:27:24 PST
Created attachment 185128 [details] Patch
Gyuyoung Kim
Comment 3 2013-01-28 18:33:29 PST
Comment on attachment 185128 [details] Patch rs=me
Jae Hyun Park
Comment 4 2013-01-28 20:08:43 PST
Created attachment 185140 [details] Patch for landing
Jae Hyun Park
Comment 5 2013-01-28 22:23:06 PST
Created attachment 185155 [details] Patch for landing
Jae Hyun Park
Comment 6 2013-01-28 22:25:22 PST
I made a mistake and omitted to add UIProcess/Storage into INCLUDEPATH. The last patch fixes the build correctly.
WebKit Review Bot
Comment 7 2013-01-28 23:02:24 PST
Comment on attachment 185155 [details] Patch for landing Rejecting attachment 185155 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=gce-cq-02', 'validate-changelog', '--non-interactive', 185155, '--port=chromium-xvfb']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue /mnt/git/webkit-commit-queue/Source/WebKit2/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/16196006
Jae Hyun Park
Comment 8 2013-01-28 23:10:25 PST
Created attachment 185170 [details] Patch
WebKit Review Bot
Comment 9 2013-01-28 23:59:17 PST
Comment on attachment 185170 [details] Patch Clearing flags on attachment: 185170 Committed r141068: <http://trac.webkit.org/changeset/141068>
WebKit Review Bot
Comment 10 2013-01-28 23:59:20 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.