| Summary: | [css exclusions] setting shape-inside on a parent does not relayout child blocks' inline content | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Bear Travis <betravis> | ||||||||
| Component: | CSS | Assignee: | Bear Travis <betravis> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | eric, esprehn+autocc, ojan.autocc, webkit.review.bot | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Bug Depends on: | 110995 | ||||||||||
| Bug Blocks: | 89256, 111029, 111189 | ||||||||||
| Attachments: |
|
||||||||||
Created attachment 190659 [details]
Initial Patch
Comment on attachment 190659 [details] Initial Patch View in context: https://bugs.webkit.org/attachment.cgi?id=190659&action=review r- > Source/WebCore/rendering/RenderBlock.cpp:1548 > +#if ENABLE(CSS_EXCLUSIONS) > + ExclusionShapeInsideInfo * info = exclusionShapeInsideInfo(); > + if (info) > + info->setNeedsLayout(info->shapeSizeDirty()); > + if (!relayoutChildren && (info || (info = layoutExclusionShapeInsideInfo()))) > + relayoutChildren = info->needsLayout(); > +#endif Could this possibly be folded into updateRegionsAndExclusionsLogicalSize, with that method returning a bool indicating whether or not relayoutChildren is required? Just trying to reduce the footprint of this code in layoutBlock. Created attachment 190988 [details]
Factoring code out of layoutBlock()
Comment on attachment 190988 [details]
Factoring code out of layoutBlock()
r=me
Comment on attachment 190988 [details] Factoring code out of layoutBlock() Clearing flags on attachment: 190988 Committed r144487: <http://trac.webkit.org/changeset/144487> All reviewed patches have been landed. Closing bug. |
Created attachment 185092 [details] Dynamically sets shape-inside after 5 seconds See test file. After 5 seconds, a shape-inside is applied, but inline content is not laid out. Will relayout correctly if you zoom in/out.