Bug 108125

Summary: [BlackBerry] No need to enable USE(MERSENNE_TWISTER_19937)
Product: WebKit Reporter: Laszlo Gombos <laszlo.gombos>
Component: WebKit BlackBerryAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, laszlo.gombos, manyoso, ojan.autocc, rwlbuis, webkit.review.bot, yong.li.webkit
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 108095, 108129    
Attachments:
Description Flags
proposed change rwlbuis: review+

Laszlo Gombos
Reported 2013-01-28 15:56:38 PST
BlackBerry port has both USE(OS_RANDOMNESS) and USE(MERSENNE_TWISTER_19937) defined. USE(OS_RANDOMNESS) has a priority over USE(MERSENNE_TWISTER_19937) (see RandomNumber.cpp:randomNumber) so USE(MERSENNE_TWISTER_19937) should not need to be defined.
Attachments
proposed change (1.17 KB, patch)
2013-01-28 16:00 PST, Laszlo Gombos 		rwlbuis: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Laszlo Gombos
Comment 1 2013-01-28 16:00:14 PST
Created attachment 185088 [details] proposed change
Rob Buis
Comment 2 2013-05-08 14:27:07 PDT
Comment on attachment 185088 [details] proposed change LGTM.
Laszlo Gombos
Comment 3 2013-05-10 09:16:33 PDT
This patch is a subset of http://trac.webkit.org/changeset/145179 and as such is it obsoleted/fixed by bug 111533 .
Note You need to log in before you can comment on or make changes to this bug.