Bug 108116

Summary: Handle createShadowSubtree inside of ensureUserAgentShadowRoot
Product: WebKit Reporter: Elliott Sprehn <esprehn>
Component: New BugsAssignee: Elliott Sprehn <esprehn>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarcelo, dglazkov, d-r, eric.carlson, feature-media-reviews, fmalita, mifenton, morrita, ojan.autocc, ojan, pdr, schenney, tkent, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Elliott Sprehn
Reported 2013-01-28 14:30:12 PST
Handle createShadowSubtree inside of ensureUserAgentShadowRoot
Attachments
Patch (32.08 KB, patch)
2013-01-28 14:33 PST, Elliott Sprehn 		no flags
DetailsFormatted DiffDiff
Patch for landing (32.16 KB, patch)
2013-01-28 19:54 PST, Elliott Sprehn 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Elliott Sprehn
Comment 1 2013-01-28 14:33:10 PST
Created attachment 185065 [details] Patch
Dimitri Glazkov (Google)
Comment 2 2013-01-28 14:47:08 PST
Comment on attachment 185065 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=185065&action=review Lovely. > Source/WebCore/dom/Element.cpp:1495 > + ShadowRoot* shadowRoot = ShadowRoot::create(this, ShadowRoot::UserAgentShadowRoot, ASSERT_NO_EXCEPTION).get(); Ugh, we should totally get rid of this nasty factory. It just looks bad, handing off a PassRefPtr to immediately get it unwrapped.
Elliott Sprehn
Comment 3 2013-01-28 18:29:52 PST
Comment on attachment 185065 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=185065&action=review >> Source/WebCore/dom/Element.cpp:1495 >> + ShadowRoot* shadowRoot = ShadowRoot::create(this, ShadowRoot::UserAgentShadowRoot, ASSERT_NO_EXCEPTION).get(); > > Ugh, we should totally get rid of this nasty factory. It just looks bad, handing off a PassRefPtr to immediately get it unwrapped. Yeah, I have a whole series of patches to clean this up.
Elliott Sprehn
Comment 4 2013-01-28 19:54:18 PST
Created attachment 185137 [details] Patch for landing
WebKit Review Bot
Comment 5 2013-01-28 23:48:52 PST
Comment on attachment 185137 [details] Patch for landing Clearing flags on attachment: 185137 Committed r141066: <http://trac.webkit.org/changeset/141066>
WebKit Review Bot
Comment 6 2013-01-28 23:48:58 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.